pkg/payload: code cleanups

[petr-muller]

• remove redundant DeepEqual checks (followup to a nit in OTA-817: Support ClusterVersion spec DesiredUpdate Architecture field #860)
• update deprecated ioutil.* calls
• replace ObjectReflectDiff with cmp.Diff

[jottofar]

/lgtm

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jottofar, petr-muller

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• OWNERS [jottofar,petr-muller]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[openshift-ci-robot]

/retest-required

Remaining retests: 0 against base HEAD af08109 and 2 for PR HEAD 7606b7e in total

[petr-muller]

/override e2e-agnostic-upgrade-out-of-change

Unrelated:

{Operator progressing (Deploying): DaemonSet "/openshift-network-diagnostics/network-check-target" is not available (awaiting 1 nodes)  Operator progressing (Deploying): DaemonSet "/openshift-network-diagnostics/network-check-target" is not available (awaiting 1 nodes)}

[openshift-ci]

@petr-muller: /override requires failed status contexts, check run or a prowjob name to operate on.
The following unknown contexts/checkruns were given:

• e2e-agnostic-upgrade-out-of-change

Only the following failed contexts/checkruns were expected:

• ci/prow/e2e-agnostic
• ci/prow/e2e-agnostic-operator
• ci/prow/e2e-agnostic-upgrade-into-change
• ci/prow/e2e-agnostic-upgrade-out-of-change
• ci/prow/gofmt
• ci/prow/images
• ci/prow/lint
• ci/prow/unit
• pull-ci-openshift-cluster-version-operator-master-e2e-agnostic
• pull-ci-openshift-cluster-version-operator-master-e2e-agnostic-operator
• pull-ci-openshift-cluster-version-operator-master-e2e-agnostic-upgrade-into-change
• pull-ci-openshift-cluster-version-operator-master-e2e-agnostic-upgrade-out-of-change
• pull-ci-openshift-cluster-version-operator-master-gofmt
• pull-ci-openshift-cluster-version-operator-master-images
• pull-ci-openshift-cluster-version-operator-master-lint
• pull-ci-openshift-cluster-version-operator-master-unit
• tide

If you are trying to override a checkrun that has a space in it, you must put a double quote on the context.

Details

In response to this:

/override e2e-agnostic-upgrade-out-of-change

Unrelated:

{Operator progressing (Deploying): DaemonSet "/openshift-network-diagnostics/network-check-target" is not available (awaiting 1 nodes)  Operator progressing (Deploying): DaemonSet "/openshift-network-diagnostics/network-check-target" is not available (awaiting 1 nodes)}

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[wking]

upgrade-out-of-change failed to install.

/retest

[petr-muller]

/override ci/prow/e2e-agnostic-upgrade-out-of-change

{  cache-kube-api-reused-connections was unreachable during disruption testing for at least 2s of 1h27m25s (maxAllowed=1s):

[openshift-ci]

@petr-muller: Overrode contexts on behalf of petr-muller: ci/prow/e2e-agnostic-upgrade-out-of-change

Details

In response to this:

/override ci/prow/e2e-agnostic-upgrade-out-of-change

{  cache-kube-api-reused-connections was unreachable during disruption testing for at least 2s of 1h27m25s (maxAllowed=1s):

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[openshift-ci]

@petr-muller: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.