Skip to content

[release-4.12] OCPBUGS-3352: Do not fail precondition check for UnknownUpdate #861

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
openshift-merge-robot merged 1 commit into from
Nov 9, 2022
Merged

[release-4.12] OCPBUGS-3352: Do not fail precondition check for UnknownUpdate #861

openshift-merge-robot merged 1 commit into from
Nov 9, 2022

Conversation

@openshift-cherrypick-robot
Copy link

@openshift-cherrypick-robot openshift-cherrypick-robot commented Nov 7, 2022

This is an automated cherry-pick of #856

/assign LalatenduMohanty

@LalatenduMohanty
OCPBUGS-2727: Do not fail precondition check for UnknownUpdate
3e00af8 
With this change we will not fail precondition checks when a version is not in available updates.
So users should be able to upgrade to any version with approriate client side overrides.
For example using --allow-explicit-upgrade and --to-imge flags in "oc adm upgrade"

Signed-off-by: Lalatendu Mohanty <lmohanty@redhat.com>
@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Nov 7, 2022
Merged
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Nov 7, 2022

@openshift-cherrypick-robot: Jira Issue OCPBUGS-2727 has been cloned as Jira Issue OCPBUGS-3352. Retitling PR to link against new bug.
/retitle [release-4.12] OCPBUGS-3352: Do not fail precondition check for UnknownUpdate

Details

In response to this:

This is an automated cherry-pick of #856

/assign LalatenduMohanty

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot changed the title [release-4.12] OCPBUGS-2727: Do not fail precondition check for UnknownUpdate [release-4.12] OCPBUGS-3352: Do not fail precondition check for UnknownUpdate Nov 7, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Nov 7, 2022

@openshift-cherrypick-robot: No Bugzilla bug is referenced in the title of this pull request.
To reference a bug, add 'Bug XXX:' to the title of this pull request and request another bug refresh with /bugzilla refresh.

Details

In response to this:

[release-4.12] OCPBUGS-3352: Do not fail precondition check for UnknownUpdate

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added jira/severity-important Referenced Jira bug's severity is important for the branch this PR is targeting. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. labels Nov 7, 2022
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Nov 7, 2022

@openshift-cherrypick-robot: This pull request references Jira Issue OCPBUGS-3352, which is valid. The bug has been moved to the POST state.

6 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.12.0) matches configured target version for branch (4.12.0)
  • bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)
  • dependent bug Jira Issue OCPBUGS-2727 is in the state MODIFIED, which is one of the valid states (MODIFIED, ON_QA, VERIFIED)
  • dependent Jira Issue OCPBUGS-2727 targets the "4.13.0" version, which is one of the valid target versions: 4.13.0
  • bug has dependents

Requesting review from QA contact:
/cc @jiajliu

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

This is an automated cherry-pick of #856

/assign LalatenduMohanty

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added the bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. label Nov 7, 2022
wking
wking approved these changes Nov 7, 2022
View reviewed changes
Copy link
Member

@wking wking left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Clean cherry-pick:

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Nov 7, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Nov 7, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: openshift-cherrypick-robot, wking

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 7, 2022
@LalatenduMohanty
Copy link
Member

LalatenduMohanty commented Nov 7, 2022

/label backport-risk-assessed

@openshift-ci openshift-ci bot added the backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. label Nov 7, 2022
@LalatenduMohanty
Copy link
Member

LalatenduMohanty commented Nov 7, 2022

/test e2e-agnostic-upgrade-into-change

@LalatenduMohanty
Copy link
Member

LalatenduMohanty commented Nov 7, 2022

/test e2e-agnostic-upgrade-out-of-change

1 similar comment
@LalatenduMohanty
Copy link
Member

LalatenduMohanty commented Nov 8, 2022

/test e2e-agnostic-upgrade-out-of-change

@wking
Copy link
Member

wking commented Nov 9, 2022

Three different failures which all seem orthogonal to the change this PR is making.

/override ci/prow/e2e-agnostic-upgrade-out-of-change

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Nov 9, 2022

@wking: Overrode contexts on behalf of wking: ci/prow/e2e-agnostic-upgrade-out-of-change

Details

In response to this:

Three different failures which all seem orthogonal to the change this PR is making.

/override ci/prow/e2e-agnostic-upgrade-out-of-change

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Nov 9, 2022

@openshift-cherrypick-robot: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-merge-robot openshift-merge-robot merged commit 25b0529 into openshift:release-4.12 Nov 9, 2022
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Nov 9, 2022

@openshift-cherrypick-robot: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-3352 has been moved to the MODIFIED state.

Details

In response to this:

This is an automated cherry-pick of #856

/assign LalatenduMohanty

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@wking wking wking approved these changes

@jiajliu jiajliu Awaiting requested review from jiajliu

@jottofar jottofar Awaiting requested review from jottofar

@LalatenduMohanty LalatenduMohanty Awaiting requested review from LalatenduMohanty

Assignees

@wking wking

@LalatenduMohanty LalatenduMohanty

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. jira/severity-important Referenced Jira bug's severity is important for the branch this PR is targeting. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@openshift-cherrypick-robot @openshift-ci-robot @LalatenduMohanty @wking @openshift-merge-robot