Bug 2090680: pkg/cvo/updatepayload.go: timeout payload retrieval #846

jottofar · 2022-10-06T14:56:34Z

When we separated payload load from payload apply (#683) the context used for the retrieval changed as well. It went from one that was constrained by syncTimeout (2 -4 minutes) [1] to being the unconstrained shutdownContext [2]. However if "force" is specified we explicitly set a 2 minute timeout in RetrievePayload. This commit creates a new context with a reasonable timeout for RetrievePayload regardless of "force".

[1]

cluster-version-operator/pkg/cvo/sync_worker.go

Line 605 in 57ffa7c

ctx, cancelFn := context.WithTimeout(ctx, syncTimeout)

[2]

cluster-version-operator/pkg/cvo/cvo.go

Line 413 in 57ffa7c

if err := optr.sync(shutdownContext, optr.queueKey()); err != nil {

openshift-ci · 2022-10-06T14:57:50Z

@jottofar: This pull request references Bugzilla bug 2090680, which is invalid:

expected the bug to target the "4.12.0" release, but it targets "---" instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

Details

In response to this:

WIP: Bug 2090680: pkg/cvo/updatepayload.go: timeout payload retrieval

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

jottofar · 2022-10-06T20:51:32Z

/bugzilla refresh

openshift-ci · 2022-10-06T20:51:42Z

@jottofar: This pull request references Bugzilla bug 2090680, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug

bug is open, matching expected state (open)
bug target release (4.12.0) matches configured target release for branch (4.12.0)
bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

Requesting review from QA contact:
/cc @jiajliu

Details

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

petr-muller · 2022-10-07T09:38:51Z

/cc

jottofar · 2022-10-07T15:07:28Z

/retest

openshift-ci · 2022-10-07T15:11:46Z

@jottofar: This pull request references Bugzilla bug 2090680, which is valid.

3 validation(s) were run on this bug

bug is open, matching expected state (open)
bug target release (4.12.0) matches configured target release for branch (4.12.0)
bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

Requesting review from QA contact:
/cc @jiajliu

Details

In response to this:

WIP: Bug 2090680: pkg/cvo/updatepayload.go: timeout payload retrieval

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

petr-muller · 2022-10-10T17:19:57Z

/lgtm
/hold

I don't consider myself a CVO expert yet to be 100% this cannot break anything (hence the hold), but looks good to me.

openshift-bot · 2022-10-28T16:14:22Z

/bugzilla refresh

The requirements for Bugzilla bugs have changed (BZs linked to PRs on main branch need to target OCP 4.12), recalculating validity.

openshift-ci · 2022-10-28T16:14:47Z

@openshift-bot: This pull request references Bugzilla bug 2090680, which is valid.

3 validation(s) were run on this bug

bug is open, matching expected state (open)
bug target release (4.12.0) matches configured target release for branch (4.12.0)
bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

Requesting review from QA contact:
/cc @jiajliu

Details

In response to this:

/bugzilla refresh

The requirements for Bugzilla bugs have changed (BZs linked to PRs on main branch need to target OCP 4.12), recalculating validity.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-bot · 2022-11-08T11:10:17Z

/bugzilla refresh

The requirements for Bugzilla bugs have changed (BZs linked to PRs on main branch need to target OCP 4.12), recalculating validity.

openshift-ci · 2022-11-08T11:10:49Z

@openshift-bot: This pull request references Bugzilla bug 2090680, which is invalid:

expected the bug to target the "4.13.0" release, but it targets "4.12.0" instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

Details

In response to this:

/bugzilla refresh

The requirements for Bugzilla bugs have changed (BZs linked to PRs on main branch need to target OCP 4.12), recalculating validity.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

jottofar · 2022-12-19T13:59:52Z

/test e2e-agnostic-upgrade-into-change

jottofar · 2022-12-20T13:57:28Z

/retitle WIP: Bug 2090680: pkg/cvo/updatepayload.go: timeout payload retrieval

LalatenduMohanty

/lgtm

LalatenduMohanty · 2022-12-20T21:02:48Z

/hold rethinking about the timeout value

jottofar · 2022-12-21T13:42:30Z

/retitle Bug 2090680: pkg/cvo/updatepayload.go: timeout payload retrieval

jottofar · 2022-12-21T13:43:05Z

/test e2e-agnostic-upgrade-into-change

LalatenduMohanty · 2022-12-21T17:59:24Z

/hold cancel

LalatenduMohanty

/lgtm

openshift-ci · 2022-12-21T18:00:16Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jottofar, LalatenduMohanty, petr-muller

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

~~OWNERS~~ [LalatenduMohanty,jottofar,petr-muller]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

jottofar · 2022-12-21T18:04:40Z

/bugzilla refresh

openshift-ci · 2022-12-21T18:04:50Z

@jottofar: This pull request references Bugzilla bug 2090680, which is valid.

3 validation(s) were run on this bug

bug is open, matching expected state (open)
bug target release (4.13.0) matches configured target release for branch (4.13.0)
bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

Requesting review from QA contact:
/cc @jiajliu

Details

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci-robot · 2022-12-21T23:02:05Z

/retest-required

Remaining retests: 0 against base HEAD 0969cc7 and 2 for PR HEAD 6df3fbc in total

LalatenduMohanty · 2022-12-22T04:22:19Z

/test e2e-agnostic-upgrade-into-change

jottofar · 2022-12-22T16:25:17Z

/test e2e-agnostic-upgrade-into-change

openshift-ci · 2022-12-22T19:09:04Z

@jottofar: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

openshift-ci · 2022-12-22T19:10:52Z

@jottofar: All pull requests linked via external trackers have merged:

openshift/cluster-version-operator#846

Bugzilla bug 2090680 has been moved to the MODIFIED state.

Details

In response to this:

Bug 2090680: pkg/cvo/updatepayload.go: timeout payload retrieval

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci bot requested review from LalatenduMohanty and wking October 6, 2022 15:03

openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 6, 2022

jottofar force-pushed the bug-2090680 branch 2 times, most recently from e17ccb1 to b8d7417 Compare October 6, 2022 20:46

openshift-ci bot added bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. and removed bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. labels Oct 6, 2022

openshift-ci bot requested a review from jiajliu October 6, 2022 20:51

openshift-ci bot requested a review from petr-muller October 7, 2022 09:38

jottofar force-pushed the bug-2090680 branch from b8d7417 to ecaaa42 Compare October 7, 2022 19:55

openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 10, 2022

openshift-ci bot assigned petr-muller Oct 10, 2022

openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Oct 10, 2022

openshift-ci bot added bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. and removed bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. labels Nov 8, 2022

openshift-ci bot changed the title ~~Bug 2090680: pkg/cvo/updatepayload.go: timeout payload retrieval~~ WIP: Bug 2090680: pkg/cvo/updatepayload.go: timeout payload retrieval Dec 20, 2022

openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Dec 20, 2022

LalatenduMohanty approved these changes Dec 20, 2022

View reviewed changes

openshift-ci bot assigned LalatenduMohanty Dec 20, 2022

Bug 2090680: pkg/cvo/updatepayload.go: timeout payload retrieval

6df3fbc

jottofar force-pushed the bug-2090680 branch from ecaaa42 to 6df3fbc Compare December 20, 2022 21:47

openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Dec 20, 2022

openshift-ci bot changed the title ~~WIP: Bug 2090680: pkg/cvo/updatepayload.go: timeout payload retrieval~~ Bug 2090680: pkg/cvo/updatepayload.go: timeout payload retrieval Dec 21, 2022

openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Dec 21, 2022

openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Dec 21, 2022

LalatenduMohanty approved these changes Dec 21, 2022

View reviewed changes

openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Dec 21, 2022

openshift-ci bot added bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. and removed bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. labels Dec 21, 2022

openshift-merge-robot merged commit d3a03ab into openshift:master Dec 22, 2022

petr-muller mentioned this pull request Jan 6, 2023

Revert "pkg/cvo/updatepayload.go: timeout payload retrieval" #881

Merged

petr-muller mentioned this pull request Feb 3, 2023

Bug 2090680: RetrievePayload: Improve timeouts and cover behavior with tests #896

Merged

Bug 2090680: pkg/cvo/updatepayload.go: timeout payload retrieval #846

Bug 2090680: pkg/cvo/updatepayload.go: timeout payload retrieval #846

Uh oh!

Conversation

jottofar commented Oct 6, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

openshift-ci bot commented Oct 6, 2022

Uh oh!

jottofar commented Oct 6, 2022

Uh oh!

openshift-ci bot commented Oct 6, 2022

Uh oh!

petr-muller commented Oct 7, 2022

Uh oh!

jottofar commented Oct 7, 2022

Uh oh!

openshift-ci bot commented Oct 7, 2022

Uh oh!

petr-muller commented Oct 10, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

openshift-bot commented Oct 28, 2022

Uh oh!

openshift-ci bot commented Oct 28, 2022

Uh oh!

openshift-bot commented Nov 8, 2022

Uh oh!

openshift-ci bot commented Nov 8, 2022

Uh oh!

jottofar commented Dec 19, 2022

Uh oh!

jottofar commented Dec 20, 2022

Uh oh!

LalatenduMohanty left a comment

Choose a reason for hiding this comment

Uh oh!

LalatenduMohanty commented Dec 20, 2022

Uh oh!

jottofar commented Dec 21, 2022

Uh oh!

jottofar commented Dec 21, 2022

Uh oh!

LalatenduMohanty commented Dec 21, 2022

Uh oh!

LalatenduMohanty left a comment

Choose a reason for hiding this comment

Uh oh!

openshift-ci bot commented Dec 21, 2022

Uh oh!

jottofar commented Dec 21, 2022

Uh oh!

openshift-ci bot commented Dec 21, 2022

Uh oh!

openshift-ci-robot commented Dec 21, 2022

Uh oh!

LalatenduMohanty commented Dec 22, 2022

Uh oh!

jottofar commented Dec 22, 2022

Uh oh!

openshift-ci bot commented Dec 22, 2022

Uh oh!

openshift-ci bot commented Dec 22, 2022

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

jottofar commented Oct 6, 2022 •

edited

Loading

petr-muller commented Oct 10, 2022 •

edited

Loading