lib/capability: Sort all slices after building them #827
Conversation
openshift-ci
bot
added
the
approved
We'd already been sorting the two status properties before attaching them to ClusterVersion, but we also use some of the underlying data internally, e.g. in TestCVO_InitImplicitlyEnabledCaps. By sorting after we build each slice, we don't need to worry about slice-consumers being surprised by order instability.
wking
force-pushed
the
more-cap-sorting
branch
from
a15206e to
cd4065d
Compare
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: LalatenduMohanty, wking The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
Registry uptime should be addressed by openshift/release#31518. Until then: /override ci/prow/e2e-agnostic-upgrade |
|
@wking: Overrode contexts on behalf of wking: ci/prow/e2e-agnostic-upgrade DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
@wking: all tests passed! Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
4 participants
We'd already been sorting the two status properties before attaching them to ClusterVersion, but we also use some of the underlying data internally, e.g. in
TestCVO_InitImplicitlyEnabledCaps. By sorting after we build each slice, we don't need to worry about slice-consumers being surprised by order instability.