Skip to content

Conversation

@rluders
Copy link

@rluders rluders commented Aug 3, 2022

Vendor bump after adding Insights as a capability to openshift/api.

$ go get github.com/openshift/api@dc2694e95008443da2f0fb2a3d2f7a552824c79d
$ go mod tidy
$ go mod vendor
$ git add -A go.* vendor

using:

$ go version
go version go1.17.13 linux/amd64

Used steps as in this PR

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Aug 3, 2022

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: rluders
Once this PR has been reviewed and has the lgtm label, please assign lalatendumohanty for approval by writing /assign @lalatendumohanty in a comment. For more information see:The Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@rluders
Copy link
Author

rluders commented Aug 3, 2022

/hold

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 3, 2022
- dumps the openshift/api to the commit hash with the capabilities (instructions from openshift#737)
- fix unit tests for new capabilities
@jhadvig
Copy link
Member

jhadvig commented Aug 9, 2022

Just FYI, this PR is picking up the Console capability

@rluders
Copy link
Author

rluders commented Aug 9, 2022

/retest

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Aug 9, 2022

@rluders: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/lint e5d305a link true /test lint
ci/prow/images e5d305a link true /test images
ci/prow/e2e-agnostic-upgrade e5d305a link true /test e2e-agnostic-upgrade
ci/prow/e2e-agnostic-operator e5d305a link true /test e2e-agnostic-operator
ci/prow/e2e-agnostic e5d305a link true /test e2e-agnostic
ci/prow/unit e5d305a link true /test unit

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@creydr
Copy link
Member

creydr commented Aug 11, 2022

@rluders fyi: in #817 I revendored openshift/api too (with more recent changes). I fixed the unit test failures and coauthored you (I hope this is ok)

@rluders rluders mentioned this pull request Aug 15, 2022
@LalatenduMohanty
Copy link
Member

/close as #817 has the required changes

@LalatenduMohanty
Copy link
Member

/close

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Aug 15, 2022

@LalatenduMohanty: Closed this PR.

Details

In response to this:

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot closed this Aug 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants