-
Notifications
You must be signed in to change notification settings - Fork 213
vendor: bump openshift/api to pick up Insights capability #812
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: rluders The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
/hold |
- dumps the openshift/api to the commit hash with the capabilities (instructions from openshift#737) - fix unit tests for new capabilities
0479e2a to
e5d305a
Compare
|
Just FYI, this PR is picking up the Console capability |
|
/retest |
|
@rluders: The following tests failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
/close as #817 has the required changes |
|
/close |
|
@LalatenduMohanty: Closed this PR. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Vendor bump after adding
Insightsas a capability to openshift/api.$ go get github.com/openshift/api@dc2694e95008443da2f0fb2a3d2f7a552824c79d $ go mod tidy $ go mod vendor $ git add -A go.* vendorusing: