Bug 2081895: lib/resourcebuilder: Drop Get from check*Health functions #780
Conversation
openshift-ci
bot
added
the
bugzilla/severity-medium
|
@wking: This pull request references Bugzilla bug 2081895, which is valid. The bug has been updated to refer to the pull request using the external bug tracker. 3 validation(s) were run on this bug
Requesting review from QA contact: DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
openshift-ci
bot
added
the
bugzilla/valid-bug
openshift-ci
bot
added
the
approved
wking
force-pushed
the
health-check-useless-get
branch
from
4394f43 to
5ee2da2
Compare
I'd missed these Gets in 0833bba (lib/resourcebuilder: Use actual resource in check*Health calls, 2022-05-03, openshift#771). What I'd thought was happening: 1. Pass typedObject into check*Health. 2. No status on typedObject, so check*Health passed, even if the in-cluster resource was sad. What was actually happening: 1. Pass typedObject into check*Health. 2. check*Health calls Get to see what's going on in the cluster. 3. Health check appropriately checks the health of the in-cluster resource. However, now that 0833bba is passing in the just-retrieved in-cluster resource, the check*Health Get call is an API call that we don't need to make. Dropping it here saves us and the API server a small amount of CPU cycles and network bandwidth.
wking
force-pushed
the
health-check-useless-get
branch
from
5ee2da2 to
b10eb81
Compare
|
/retest |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jottofar, wking The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/retest-required Please review the full test history for this PR and help us cut down flakes. |
3 similar comments
|
/retest-required Please review the full test history for this PR and help us cut down flakes. |
|
/retest-required Please review the full test history for this PR and help us cut down flakes. |
|
/retest-required Please review the full test history for this PR and help us cut down flakes. |
|
@wking: all tests passed! Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
@wking: All pull requests linked via external trackers have merged: Bugzilla bug 2081895 has been moved to the MODIFIED state. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
4 participants
I'd missed these Gets in 0833bba (#771). What I'd thought was happening:
typedObjectintocheck*Health.typedObject, socheck*Healthpassed, even if the in-cluster resource was sad.What was actually happening:
typedObjectintocheck*Health.check*HealthcallsGetto see what's going on in the cluster.However, now that 0833bba is passing in the just-retrieved in-cluster resource, the
check*HealthGetcall is an API call that we don't need to make. Dropping it here saves us and the API server a small amount of CPU cycles and network bandwidth.