Bug 2080429: pkg/cvo/sync_worker.go: Save overrides and capabilities #770
Conversation
openshift-ci
bot
added
bugzilla/severity-high
|
@jottofar: This pull request references Bugzilla bug 2080429, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker. 3 validation(s) were run on this bug
Requesting review from QA contact: DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
openshift-ci
bot
added
the
approved
jottofar
force-pushed
the
bug-2080429
branch
2 times, most recently
from
b552477 to
1a78860
Compare
|
/test e2e-agnostic |
wking
left a comment
wking
left a comment
There was a problem hiding this comment.
I don't entirely understand what's going on in the unit test, but the code change looks good to me. Feel free to discuss the unit tests more, or just pull the hold, as you see fit.
/lgtm
/hold
openshift-ci
bot
added
the
do-not-merge/hold
openshift-ci
bot
added
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jottofar, wking The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/retest-required Please review the full test history for this PR and help us cut down flakes. |
1 similar comment
|
/retest-required Please review the full test history for this PR and help us cut down flakes. |
|
/retest |
|
/retest-required Please review the full test history for this PR and help us cut down flakes. |
1 similar comment
|
/retest-required Please review the full test history for this PR and help us cut down flakes. |
|
/retest-required Please review the full test history for this PR and help us cut down flakes. |
1 similar comment
|
/retest-required Please review the full test history for this PR and help us cut down flakes. |
|
@jottofar: all tests passed! Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
@jottofar: All pull requests linked via external trackers have merged: Bugzilla bug 2080429 has been moved to the MODIFIED state. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
4 participants
if changed before returning due to a desired update payload load failure.