vendor: Bump library-go#710
Conversation
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: wking The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
Bot
added
the
approved
Generated with: $ go get github.com/openshift/library-go $ go mod tidy $ go mod vendor $ git add -A go.* vendor using: $ go version go version go1.17.3 linux/amd64
Catching up with [1]. [1]: kubernetes/kubernetes#105979
|
kube recommends using |
|
Hi, just checking what is the status of this? |
|
imo this needs to be closed in favor of #716, which implements a new comparison |
Because ObjectReflectDiff is deprecated and doesn't handle the internal 'id' property. We're using the recommended replacement [1]. [1]: https://github.com/kubernetes/apimachinery/blob/de7147de41c9331e4697399f48564f1d970cc01e/pkg/util/diff/diff.go#L70
Now that we're using these in the pkg/payload unit tests. Generated with: $ go mod tidy $ go mod vendor $ git add -A go.* vendor using: $ go version go version go1.17.3 linux/amd64
|
@wking: The following tests failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
#716 picked up my commits and builds on top, so no need for this separate PR. /close |
|
@wking: Closed this PR. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
4 participants
Generated with:
using:
I was originally planning on using this to pull in
LeaderElectionSNOConfigfrom openshift/library-go#1242, but due to the size of the diff, I figured I might as well file the vendor bump as a stand-alone PR.