Skip to content

Bug 2029750: pkg/start: Log and continue when we fail to retrieve the feature gate #706

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
openshift-merge-robot merged 2 commits into from
Dec 7, 2021
Merged

Bug 2029750: pkg/start: Log and continue when we fail to retrieve the feature gate #706

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
bbc00e4
pkg/featurechangestopper: Log initial state
wking Dec 7, 2021
90b1454
pkg/start: Log and continue when we fail to retrieve the feature gate
wking Dec 7, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions pkg/featurechangestopper/techpreviewchangestopper.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -94,15 +94,15 @@ func (c *TechPreviewChangeStopper) Run(ctx context.Context, shutdownFn context.C
}()
c.shutdownFn = shutdownFn

klog.Infof("Starting stop-on-techpreview-change controller")
klog.Infof("Starting stop-on-techpreview-change controller with %s %t.", configv1.TechPreviewNoUpgrade, c.startingTechPreviewState)

// wait for your secondary caches to fill before starting your work
if !cache.WaitForCacheSync(ctx.Done(), c.cacheSynced...) {
return errors.New("feature gate cache failed to sync")
}

err := wait.PollImmediateUntilWithContext(ctx, 30*time.Second, c.runWorker)
klog.Infof("Shutting down stop-on-techpreview-change controller")
klog.Info("Shutting down stop-on-techpreview-change controller")
return err
}

Expand Down
2 changes: 1 addition & 1 deletion pkg/start/start.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -142,7 +142,7 @@ func (o *Options) Run(ctx context.Context) error {
case apierrors.IsNotFound(err):
includeTechPreview = false // if we have no featuregates, then we aren't tech preview
case err != nil:
return fmt.Errorf("error getting featuregate value: %v", err)
klog.Warningf("Error getting featuregate value: %v", err)
default:
includeTechPreview = gate.Spec.FeatureSet == configv1.TechPreviewNoUpgrade
}
Expand Down