Exclude featuregate.release.openshift/tech-preview=true manifests #694
Conversation
openshift-ci
bot
added
the
do-not-merge/work-in-progress
deads2k
changed the title
openshift-ci
bot
removed
the
do-not-merge/work-in-progress
|
Have reviewed, have nothing to add, LGTM. Won't add the label as there are some linter errors that may want to be addressed |
|
thanks! |
|
/approve |
openshift-ci
bot
added
the
approved
This allows consistency between invocations so that the value never hanges after the operator instance is created. Since the binary will shutdown on featuregate value change, this simplifies the flow.
changes This value changes infrequently and can never be disabled. This simple mechanism restarts the CVO so that when the CVO starts again it will start creating using techpreview manifests
|
This PR also needs corresponding documentation in https://github.com/openshift/enhancements/tree/master/dev-guide/cluster-version-operator/dev |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: deads2k, LalatenduMohanty, wking The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
sandbox error is orthogonal: /override ci/prow/e2e-agnostic-upgrade |
|
@wking: Overrode contexts on behalf of wking: ci/prow/e2e-agnostic-upgrade DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
Looks like #703 snuck in in parallel, and now Tide is retesting the world against the new target commit, but I want to close out this epic and move on to other things, so skip the slow stuff: /override ci/prow/e2e-agnostic |
|
@wking: Overrode contexts on behalf of wking: ci/prow/e2e-agnostic, ci/prow/e2e-agnostic-operator DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
From the enhancement [1]: During bootstrapping, the CVO will assume no feature sets are enabled until it can successfully retrieve `featuregates.config.openshift.io` from the Kubernetes API server. So this softens the error from 18dd189 (simplify includeTechPreview flag to be a static bool, 2021-11-22, openshift#694) to be log-and-continue. If it turns out that we actually were TechPreviewNoUpgrade, the TechPreviewChangeStopper controller will eventually succeed in pulling the feature-gate, notice, and ask the CVO to shut down. In the meantime, the CVO will have been able to get a head start on reconciling the vast majority of manifests which are not tech-preview. [1]: https://github.com/openshift/enhancements/blame/f74ffe7776f40dbd096b9ca10c27ee7a0a579e58/enhancements/update/cvo-techpreview-manifests.md#L70-L71
We have a number of different annotations all working together now, so logging exclusions with our reasoning will help folks who are debugging "why is my manifest not being reconciled?". And while this will create a number of logs for some profiles, we we already log each reconciled manifest with every sync cycle, so the volume increase isn't huge compared to our existing log rate. This is primarily a dev-time issue, which argues against log spew for production clusters, but since 72599d3 (Exclude featuregate.release.openshift/tech-preview=true manifests, 2021-04-13, openshift#694), there's been the dynamic tech-preview business, so there is now more utility in production logging around this than there was before.
7 participants
rebase and push of #546
It still needs an auto-shutdown and probably (haven't yet looked) a few tests.
Implements openshift/enhancements#957