Bug 2011954: pkg/cvo/upgradeable: Include messages for multiple-reason Upgradeable=False #672
Conversation
…graded" Because folks can force to override the CVO's precondition guards, including the Upgradeable=False guard. The "cannot" wording is from way back in 0452814 (cvo: long running upgradeable sync worker, 2019-09-05, openshift#243). Generated with: $ sed -i 's/cannot be upgraded/should not be upgraded/g' $(git grep -l 'cannot be upgraded')
openshift-ci
bot
added
bugzilla/severity-urgent
|
@wking: This pull request references Bugzilla bug 2011954, which is invalid:
Comment DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
openshift-ci
bot
added
the
approved
…=False
Because:
Upgradeable=False
Reason: MultipleReasons
Message: Cluster cannot be upgraded between minor versions for multiple reasons: AdminAckRequired,IncompatibleOperatorsInstalled
doesn't include all the useful information needed to resolve those
issues. This pivots to using the same approach we use today when
aggregating multiple Upgradeable=False ClusterOperators.
Also shift the patch-blocking overrides check in front of the other
minor blocking checks. It's more important (because it blocks more
targets), and it also will not included a nested sub-list (which might
be confusing, because today I'm not adding indents or any such markers
to make it easy to distinguish levels in a nested list hierarchy).
This cherry-picks 0c742e5 (pkg/cvo/upgradeable: Include messages
for multiple-reason Upgradeable=False, 2021-10-07, openshift#671) back to 4.8,
with a minor context change because 4.8 doesn't have 0afb8a8 (Add a
manifest annotation to be used for object deletion, 2020-08-17, openshift#438).
wking
force-pushed
the
include-messages-in-multi-reason-upgradeable-message-4.8
branch
from
324934d to
9fd50d3
Compare
|
/retest-required Please review the full test history for this PR and help us cut down flakes. |
2 similar comments
|
/retest-required Please review the full test history for this PR and help us cut down flakes. |
|
/retest-required Please review the full test history for this PR and help us cut down flakes. |
|
/bugzilla refresh Recalculating validity in case the underlying Bugzilla bug has changed. |
|
@openshift-bot: This pull request references Bugzilla bug 2011954, which is invalid:
Comment DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/retest-required Please review the full test history for this PR and help us cut down flakes. |
2 similar comments
|
/retest-required Please review the full test history for this PR and help us cut down flakes. |
|
/retest-required Please review the full test history for this PR and help us cut down flakes. |
|
/lgtm |
|
Verified and passed /label qe-approved |
openshift-ci
bot
added
the
qe-approved
|
/bugzilla cc-qa |
openshift-ci
bot
added
bugzilla/valid-bug
|
@jianlinliu: This pull request references Bugzilla bug 2011954, which is valid. 6 validation(s) were run on this bug
Requesting review from QA contact: DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jianlinliu, LalatenduMohanty, wking The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/bugzilla refresh |
|
@sdodson: This pull request references Bugzilla bug 2011954, which is valid. 6 validation(s) were run on this bug
Requesting review from QA contact: DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
sdodson
added
the
cherry-pick-approved
|
@wking: All pull requests linked via external trackers have merged: Bugzilla bug 2011954 has been moved to the MODIFIED state. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
wking
deleted the
include-messages-in-multi-reason-upgradeable-message-4.8
branch
6 participants
Backporting #611 and #671 to 4.8. #671 addresses the bug. #611 helps it apply with fewer conflicts.