Skip to content

docs/dev/operators: Document ComponentOverride injection #65

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
openshift-merge-robot merged 1 commit into from
Dec 12, 2018
Merged

docs/dev/operators: Document ComponentOverride injection #65

openshift-merge-robot merged 1 commit into from
Dec 12, 2018

Conversation

@wking
Copy link
Member

@wking wking commented Dec 5, 2018

To help devs to test one-off object changes.

Builds on #59; review that first.

CC @abhinavdahiya, @runcom

@openshift-ci-robot openshift-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Dec 5, 2018
@wking wking force-pushed the cluster-version-edits branch 2 times, most recently from 6940661 to 636905e Compare December 5, 2018 06:20
@abhinavdahiya
Copy link
Contributor

abhinavdahiya commented Dec 5, 2018

Can you drop #59 changes. They don't seem related

@wking wking force-pushed the cluster-version-edits branch from 636905e to 60f3eed Compare December 11, 2018 11:28
@openshift-ci-robot openshift-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Dec 11, 2018
@wking wking force-pushed the cluster-version-edits branch from 60f3eed to 98e1d72 Compare December 11, 2018 11:37
@wking
Copy link
Member Author

wking commented Dec 11, 2018

Ok, I've pushed 636905e -> 98e1d72, addressing all of your review (I think ;), except for the jq vs. JSONPath one. More on why I'm using jq here. I'm happy to switch to JSONPath if there's a way to get it to spit out JSON objects. And I'll grudgingly switch to JSONPath in the absence of JSON-object output if you really don't want to involve jq. Thoughts?

@abhinavdahiya
Copy link
Contributor

abhinavdahiya commented Dec 11, 2018

/lgtm
/retest

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Dec 11, 2018
@wking
docs/dev/clusterversion: Document ComponentOverride injection
f83e20b 
To help devs to test one-off object changes.  Also document how to
retrieve the current cluster version.
@wking wking force-pushed the cluster-version-edits branch from 98e1d72 to f83e20b Compare December 11, 2018 19:01
@openshift-ci-robot openshift-ci-robot removed the lgtm Indicates that a PR is ready to be merged. label Dec 11, 2018
@wking
Copy link
Member Author

wking commented Dec 11, 2018

Oops, I just pushed 98e1d72 -> f83e20b adding notes about disabling the CVO completely. @abhinavdahiya, can you take another look and maybe re-/lgtm?

@abhinavdahiya
Copy link
Contributor

abhinavdahiya commented Dec 11, 2018

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Dec 11, 2018
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Dec 11, 2018

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: abhinavdahiya, wking

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:
  • OWNERS [abhinavdahiya,wking]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-bot
Copy link
Contributor

openshift-bot commented Dec 12, 2018

/retest

Please review the full test history for this PR and help us cut down flakes.

3 similar comments
@openshift-bot
Copy link
Contributor

openshift-bot commented Dec 12, 2018

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

openshift-bot commented Dec 12, 2018

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

openshift-bot commented Dec 12, 2018

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-merge-robot openshift-merge-robot merged commit eec5a8f into openshift:master Dec 12, 2018
@wking wking deleted the cluster-version-edits branch April 3, 2019 07:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@crawford crawford Awaiting requested review from crawford

@smarterclayton smarterclayton Awaiting requested review from smarterclayton

Assignees

@abhinavdahiya abhinavdahiya

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@wking @abhinavdahiya @openshift-ci-robot @openshift-bot @openshift-merge-robot