Skip to content

[release-4.7] Bug 1970272: Log object updates and show existing/required diff #589

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
openshift-merge-robot merged 3 commits into from
Jun 11, 2021
Merged

[release-4.7] Bug 1970272: Log object updates and show existing/required diff #589

openshift-merge-robot merged 3 commits into from
Jun 11, 2021

Conversation

@openshift-cherrypick-robot
Copy link

@openshift-cherrypick-robot openshift-cherrypick-robot commented Jun 10, 2021

This is an automated cherry-pick of #561

/assign vrutkovs

Vadim Rutkovsky added 3 commits June 10, 2021 08:16
lib: log when object is being created
58b0c6f
Log object updates and show existing/required diff
f550d0f
applyUnstructured: avoid hotlooping
5638512 
* create synthetic `expected` = `required` + skipped keys from `existing`
* create a diff of `expected` and `existing`
* if diff is empty skip .Update() call
@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Jun 10, 2021
Merged
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jun 10, 2021

@openshift-cherrypick-robot: Bugzilla bug 1879184 has been cloned as Bugzilla bug 1970272. Retitling PR to link against new bug.
/retitle [release-4.7] Bug 1970272: Log object updates and show existing/required diff

Details

In response to this:

[release-4.7] Bug 1879184: Log object updates and show existing/required diff

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot changed the title [release-4.7] Bug 1879184: Log object updates and show existing/required diff [release-4.7] Bug 1970272: Log object updates and show existing/required diff Jun 10, 2021
@openshift-ci openshift-ci bot added bugzilla/severity-medium Referenced Bugzilla bug's severity is medium for the branch this PR is targeting. bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. labels Jun 10, 2021
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jun 10, 2021

@openshift-cherrypick-robot: This pull request references Bugzilla bug 1970272, which is invalid:

  • expected dependent Bugzilla bug 1879184 to be in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), CLOSED (CURRENTRELEASE), but it is ON_QA instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

Details

In response to this:

[release-4.7] Bug 1970272: Log object updates and show existing/required diff

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@vrutkovs
Copy link

vrutkovs commented Jun 10, 2021

/test unit

1 similar comment
@vrutkovs
Copy link

vrutkovs commented Jun 10, 2021

/test unit

@vrutkovs
Copy link

vrutkovs commented Jun 11, 2021

/bugzilla refresh

@openshift-ci openshift-ci bot added bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. and removed bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. labels Jun 11, 2021
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jun 11, 2021

@vrutkovs: This pull request references Bugzilla bug 1970272, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

6 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.7.z) matches configured target release for branch (4.7.z)
  • bug is in the state NEW, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)
  • dependent bug Bugzilla bug 1879184 is in the state VERIFIED, which is one of the valid states (VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), CLOSED (CURRENTRELEASE))
  • dependent Bugzilla bug 1879184 targets the "4.8.0" release, which is one of the valid target releases: 4.8.0
  • bug has dependents

No GitHub users were found matching the public email listed for the QA contact in Bugzilla ([email protected]), skipping review request.

Details

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@vrutkovs
Copy link

vrutkovs commented Jun 11, 2021

/approve
/retest

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 11, 2021
vrutkovs
vrutkovs approved these changes Jun 11, 2021
View reviewed changes
Copy link

@vrutkovs vrutkovs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jun 11, 2021
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jun 11, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: openshift-cherrypick-robot, vrutkovs

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ecordell ecordell added the cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. label Jun 11, 2021
@openshift-merge-robot openshift-merge-robot merged commit f3d2508 into openshift:release-4.7 Jun 11, 2021
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jun 11, 2021

@openshift-cherrypick-robot: All pull requests linked via external trackers have merged:

Bugzilla bug 1970272 has been moved to the MODIFIED state.

Details

In response to this:

[release-4.7] Bug 1970272: Log object updates and show existing/required diff

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot mentioned this pull request Jun 16, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@LalatenduMohanty LalatenduMohanty Awaiting requested review from LalatenduMohanty

@smarterclayton smarterclayton Awaiting requested review from smarterclayton

1 more reviewer

@vrutkovs vrutkovs vrutkovs approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@vrutkovs vrutkovs

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/severity-medium Referenced Bugzilla bug's severity is medium for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@openshift-cherrypick-robot @vrutkovs @ecordell @openshift-merge-robot