Remove k8s.io v1beta1 APIs no longer served #545
Conversation
|
@jottofar: This pull request references Bugzilla bug 1947797, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker. 3 validation(s) were run on this bug
No GitHub users were found matching the public email listed for the QA contact in Bugzilla ([email protected]), skipping review request. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
openshift-ci-robot
added
bugzilla/severity-high
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jottofar The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci-robot
added
the
approved
|
/test unit |
jottofar
force-pushed
the
bug-1947797
branch
2 times, most recently
from
a1b0262 to
a207e2c
Compare
|
/test unit |
|
/retitle Bug 1947797: Remove k8s.io v1beta1 APIs no longer served |
openshift-ci-robot
changed the title
|
@jottofar: This pull request references Bugzilla bug 1947797, which is valid. 3 validation(s) were run on this bug
No GitHub users were found matching the public email listed for the QA contact in Bugzilla ([email protected]), skipping review request. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/test unit |
|
/retest |
|
I don't think this is solution for 4.8 for the problem at hand. The complain in the BZ is about CVO having two CRD manifests in its payload that are v1beta1. This PR is good, but I would not merge it before 4.9 because during upgrade/downgrade between 4.7 and 4.8 the CVO mifght "see" v1beta1 CRDs manifests that are completely valid. /hold |
openshift-ci-robot
added
the
do-not-merge/hold
In kuberentes v1.22 including apiextensions.k8s.io/v1beta1 version of CustomResourceDefinition, apiregistration.k8s.io/v1beta1 version of APIService, and rbac.authorization.k8s.io/v1beta1 version of ClusterRole, ClusterRoleBinding, Role, and RoleBinding. Use is currently causing the DeprecatedAPIInUse alert to fire in 4.8 clusters.
|
/retitle Remove k8s.io v1beta1 APIs no longer served |
openshift-ci-robot
changed the title
|
@jottofar: No Bugzilla bug is referenced in the title of this pull request. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
openshift-ci-robot
removed
bugzilla/severity-high
|
@jottofar: The following tests failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
/close |
|
@jottofar: PR needs rebase. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
openshift-ci
bot
added
the
needs-rebase
|
@jottofar: Closed this PR. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
3 participants
k8s.io v1beta1 APIs are no longer served In kuberentes v1.22. Therefore removing apiextensions.k8s.io/v1beta1 version of
CustomResourceDefinition, apiregistration.k8s.io/v1beta1 version of APIService, and rbac.authorization.k8s.io/v1beta1 version of ClusterRole, ClusterRoleBinding, Role, and RoleBinding. Kubernetes recommended action is to use the v1 API versions which are already in use in CVO. It supported both versions.
Use of the v1beta1 versions is currently causing the DeprecatedAPIInUse alert to fire in 4.8 clusters.