lib/resourcemerge/rbac: Reconcile ClusterRole.AggregationRule #544
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This wasn't covered when ClusterRole reconciliation landed in 697cbf6 (lib: update resource{read,merge,apply} to add new objects, 2018-08-20, openshift#10), but the property existed even back then: $ git grep -A20 'type ClusterRole struct' 697cbf6 | grep '[-][[:space:]]Aggrega tionRule' 697cbf6:vendor/k8s.io/api/rbac/v1/types.go- AggregationRule *AggregationRule `json:"aggregationRule,omitempty" protobuf:"bytes,3,opt,name=aggregationRule"` 697cbf6:vendor/k8s.io/api/rbac/v1alpha1/types.go- AggregationRule *AggregationRule `json:"aggregationRule,omitempty" protobuf:"bytes,3,opt,name=aggregationRule"` 697cbf6:vendor/k8s.io/api/rbac/v1beta1/types.go- AggregationRule *AggregationRule `json:"aggregationRule,omitempty" protobuf:"bytes,3,opt,name=aggregationRule"` and now folks want to use aggregationRule for something [1]. [1]: openshift/machine-api-operator#795
wking
force-pushed
the
sync-cluster-role-aggregationRule
branch
from
4f7d84e to
8b5c8b8
Compare
openshift-ci-robot
added
lgtm
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: JoelSpeed, LalatenduMohanty, wking The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Contributor
|
/retest Please review the full test history for this PR and help us cut down flakes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This wasn't covered when ClusterRole reconciliation landed in 697cbf6 (#10), but the property existed even back then:
and now folks want to use
aggregationRulefor something: openshift/machine-api-operator#795.