Skip to content

Conversation

@RiRa12621
Copy link

@RiRa12621 RiRa12621 commented Jan 29, 2021

SRE-P has commited to feed findings and changes in regards to alerts back to upstream, this change is a follow up to https://issues.redhat.com/browse/OSD-6327

We are obeying the following standards for alert levels and recommend every component team to do so to:


    Critical: An issue, that needs to page a person to take instant action
    Warning: An issue, that needs to be worked on but in the regular work queue or for during office hours rather than paging the oncall
    Info: Is meant to support a trouble shooting process by informing about a non-normal situation for one or more systems but not worth a page or ticket on its own.

reference

This therefore is a warning level alert. No one should be paged for it in the middle of the night but we still want cluster owners to eventually fix this.

/cc @jewzaam @wking @cblecker

@RiRa12621
Copy link
Author

/assign @wking

@vrutkovs
Copy link

If CVO can't reach OSUS this would only impair cluster upgrades. Similar to other alerts - like ClusterNotUpgradable - +1 on setting this as a warning instead of "needs immediate resolution".

/approve

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 29, 2021
@LalatenduMohanty
Copy link
Member

CVO not able to reach OpenShift update service does not effect cluster availability. Also we do not need to wake up someone middle of the night to fix this. Hence I am in favor of making this a warning.

Copy link
Member

@LalatenduMohanty LalatenduMohanty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/hold For giving @wking sometime to put his views

@openshift-ci-robot openshift-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 29, 2021
@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Jan 29, 2021
@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: LalatenduMohanty, RiRa12621, vrutkovs

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:
  • OWNERS [LalatenduMohanty,vrutkovs]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sdodson
Copy link
Member

sdodson commented Jan 29, 2021

@RiRa12621 Which branch are you looking to have this backported to?

@RiRa12621
Copy link
Author

4.6 would be good.
I'll open a BZ @sdodson

@LalatenduMohanty
Copy link
Member

/hold cancel

@openshift-ci-robot openshift-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Feb 2, 2021
@RiRa12621
Copy link
Author

/retitle Bug 1926310: install/0000_90_cluster-version-operator_02_servicemonitor.yaml: adjust "CannotRetrieveUpdates" to "warning"

@sdodson sdodson changed the title install/0000_90_cluster-version-operator_02_servicemonitor.yaml: adjust "CannotRetrieveUpdates" to "warning" Bug 1926310: adjust "CannotRetrieveUpdates" to "warning" Feb 8, 2021
@openshift-ci-robot openshift-ci-robot added bugzilla/severity-low Referenced Bugzilla bug's severity is low for the branch this PR is targeting. bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. labels Feb 8, 2021
@openshift-ci-robot
Copy link
Contributor

@RiRa12621: This pull request references Bugzilla bug 1926310, which is invalid:

  • expected the bug to target the "4.8.0" release, but it targets "---" instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

Details

In response to this:

Bug 1926310: adjust "CannotRetrieveUpdates" to "warning"

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@sdodson
Copy link
Member

sdodson commented Feb 8, 2021

/bugzilla refresh

@openshift-ci-robot openshift-ci-robot added bugzilla/severity-high Referenced Bugzilla bug's severity is high for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. and removed bugzilla/severity-low Referenced Bugzilla bug's severity is low for the branch this PR is targeting. labels Feb 8, 2021
@openshift-ci-robot
Copy link
Contributor

@sdodson: This pull request references Bugzilla bug 1926310, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.8.0) matches configured target release for branch (4.8.0)
  • bug is in the state NEW, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)
Details

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot removed the bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. label Feb 8, 2021
@openshift-ci-robot openshift-ci-robot changed the title Bug 1926310: adjust "CannotRetrieveUpdates" to "warning" Bug 1926310: install/0000_90_cluster-version-operator_02_servicemonitor.yaml: adjust "CannotRetrieveUpdates" to "warning" Feb 8, 2021
@sdodson
Copy link
Member

sdodson commented Feb 8, 2021

/refresh

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

2 similar comments
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-merge-robot openshift-merge-robot merged commit 0e3832c into openshift:master Feb 9, 2021
@openshift-ci-robot
Copy link
Contributor

@RiRa12621: All pull requests linked via external trackers have merged:

Bugzilla bug 1926310 has been moved to the MODIFIED state.

Details

In response to this:

Bug 1926310: install/0000_90_cluster-version-operator_02_servicemonitor.yaml: adjust "CannotRetrieveUpdates" to "warning"

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@sdodson
Copy link
Member

sdodson commented Feb 9, 2021

/cherry-pick release-4.7

@openshift-cherrypick-robot

@sdodson: new pull request created: #516

Details

In response to this:

/cherry-pick release-4.7

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/severity-high Referenced Bugzilla bug's severity is high for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

9 participants