Bug 1883705: *: Move to klog v2 #462

wking · 2020-09-29T23:24:56Z

When we moved to 0.19 Kube tooling in ef236c3 (#420), the tooling moved to klog v2. Port our local klog consumers so we don't have to worry about configuring multiple klogs.

Generated with:

$ sed -i 's|^go 1.13|go 1.15|' go.mod
$ sed -i 's|k8s.io/klog v1.0.0|k8s.io/klog/v2 v2.3.0|' go.mod
$ sed -i 's|"k8s.io/klog"|"k8s.io/klog/v2"|' $(git grep -l k8s.io/klog cmd lib pkg)
$ sed -i 's|klog.V(\([0-9]\)) |klog.V(\1).Enabled() |' $(git grep -l klog.V cmd lib pkg)
$ go mod tidy
$ go mod vendor
$ git add -A go.* vendor

using:

$ go version
go version go1.15.2 linux/amd64

The change to Go 1.15 catches us up with 1d9a319 (#457).

openshift-ci-robot · 2020-09-29T23:25:03Z

@wking: This pull request references Bugzilla bug 1883705, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug

bug is open, matching expected state (open)
bug target release (4.6.0) matches configured target release for branch (4.6.0)
bug is in the state NEW, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

Details

In response to this:

Bug 1883705: *: Move to klog v2

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci-robot · 2020-09-29T23:25:57Z

@wking: This pull request references Bugzilla bug 1883705, which is valid.

3 validation(s) were run on this bug

bug is open, matching expected state (open)
bug target release (4.6.0) matches configured target release for branch (4.6.0)
bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

Details

In response to this:

Bug 1883705: *: Move to klog v2

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

When we moved to 0.19 Kube tooling in ef236c3 (vendor: Bump client-go and library-go to current 4.6 tips 2020-07-24, openshift#420), the tooling moved to klog v2. Port our local klog consumers so we don't have to worry about configuring multiple klogs [1]. Generated with: $ sed -i 's|^go 1.13|go 1.15|' go.mod $ sed -i 's|k8s.io/klog v1.0.0|k8s.io/klog/v2 v2.3.0|' go.mod $ sed -i 's|"k8s.io/klog"|"k8s.io/klog/v2"|' $(git grep -l k8s.io/klog cmd lib pkg) $ sed -i 's|klog.V($[0-9]$) |klog.V(\1).Enabled() |' $(git grep -l klog.V cmd lib pkg) $ go mod tidy $ go mod vendor $ git add -A go.* vendor using: $ go version go version go1.15.2 linux/amd64 The change to Go 1.15 catches us up with 1d9a319 (Dockerfile.rhel: Bump to Go 1.15, 2020-09-16, openshift#457). [1]: https://bugzilla.redhat.com/show_bug.cgi?id=1883705

vrutkovs · 2020-09-30T08:37:19Z

/retest

vrutkovs

/lgtm

oshoval

Looking on the snippet,
aint the commands with grep -l will stop on the first one, (according man grep) and they should sed on all the files ?

$ sed -i 's|^go 1.13|go 1.15|' go.mod
$ sed -i 's|k8s.io/klog v1.0.0|k8s.io/klog/v2 v2.3.0|' go.mod
$ sed -i 's|"k8s.io/klog"|"k8s.io/klog/v2"|' $(git grep -l k8s.io/klog cmd lib pkg)
$ sed -i 's|klog.V(\([0-9]\)) |klog.V(\1).Enabled() |' $(git grep -l klog.V cmd lib pkg)
$ go mod tidy
$ go mod vendor
$ git add -A go.* vendor

vrutkovs · 2020-09-30T09:41:57Z

aint the commands with grep -l will stop on the first one

git grep -l doesn't stop on the first one

openshift-bot · 2020-09-30T10:20:36Z

/retest

Please review the full test history for this PR and help us cut down flakes.

LalatenduMohanty · 2020-09-30T11:10:26Z

/lgtm

openshift-ci-robot · 2020-09-30T11:10:43Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: LalatenduMohanty, vrutkovs, wking

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

~~OWNERS~~ [LalatenduMohanty,vrutkovs,wking]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

openshift-bot · 2020-09-30T11:51:36Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2020-09-30T12:04:36Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2020-09-30T13:35:39Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2020-09-30T15:19:02Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2020-09-30T17:16:01Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2020-09-30T17:42:02Z

/retest

Please review the full test history for this PR and help us cut down flakes.

wking · 2020-09-30T18:32:30Z

e2e:


level=error msg="Error: Error when reading or editing ComputeRouterNat \"openshift-gce-devel-ci/us-east1/ci-op-7jn3ir6n-11cd2-gw5b7-router/ci-op-7jn3ir6n-11cd2-gw5b7-nat-worker\": googleapi: Error 403: Quota exceeded for quota group 'ReadGroup' and limit 'Read requests per 100 seconds' of service 'compute.googleapis.com' for consumer 'project_number:1053217076791'., rateLimitExceeded"

So that's not specific to this PR.

openshift-bot · 2020-09-30T19:26:07Z

/retest

Please review the full test history for this PR and help us cut down flakes.

wking · 2020-09-30T19:50:16Z

e2e had some Kube-API components alerting:

        "ALERTS{alertname!~\"Watchdog|AlertmanagerReceiversNotConfigured|PrometheusRemoteWriteDesiredShards\",alertstate=\"firing\",severity!=\"info\"} >= 1": {
            s: "promQL query: ALERTS{alertname!~\"Watchdog|AlertmanagerReceiversNotConfigured|PrometheusRemoteWriteDesiredShards\",alertstate=\"firing\",severity!=\"info\"} >= 1 had reported incorrect results:\n[{\"metric\":{\"__name__\":\"ALERTS\",\"alertname\":\"KubeAPIDown\",\"alertstate\":\"firing\",\"severity\":\"critical\"},\"value\":[1601490640.792,\"1\"]},{\"metric\":{\"__name__\":\"ALERTS\",\"alertname\":\"KubeControllerManagerDown\",\"alertstate\":\"firing\",\"severity\":\"critical\"},\"value\":[1601490640.792,\"1\"]},{\"metric\":{\"__name__\":\"ALERTS\",\"alertname\":\"KubeSchedulerDown\",\"alertstate\":\"firing\",\"severity\":\"critical\"},\"value\":[1601490640.792,\"1\"]}]",

openshift-bot · 2020-09-30T21:09:20Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2020-09-30T22:53:21Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2020-10-01T00:37:23Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2020-10-01T02:21:19Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2020-10-01T03:52:20Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2020-10-01T05:36:20Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2020-10-01T07:33:23Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2020-10-01T08:51:34Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2020-10-01T09:30:21Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2020-10-01T11:14:13Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2020-10-01T13:24:08Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2020-10-01T19:28:12Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2020-10-01T21:51:12Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2020-10-01T23:22:14Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2020-10-02T01:06:17Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2020-10-02T01:19:20Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2020-10-02T02:37:18Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2020-10-02T03:03:16Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2020-10-02T04:47:13Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-ci-robot · 2020-10-02T07:16:01Z

@wking: All pull requests linked via external trackers have merged:

openshift/cluster-version-operator#462

Bugzilla bug 1883705 has been moved to the MODIFIED state.

Details

In response to this:

Bug 1883705: *: Move to klog v2

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci-robot added the bugzilla/severity-high Referenced Bugzilla bug's severity is high for the branch this PR is targeting. label Sep 29, 2020

openshift-ci-robot added the bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. label Sep 29, 2020

openshift-ci-robot requested review from sdodson and vrutkovs September 29, 2020 23:25

openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 29, 2020

wking force-pushed the klog-v2 branch from ea6ca01 to 24a0f5b Compare September 29, 2020 23:26

vrutkovs approved these changes Sep 30, 2020

View reviewed changes

openshift-ci-robot assigned vrutkovs Sep 30, 2020

openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Sep 30, 2020

oshoval reviewed Sep 30, 2020

View reviewed changes

openshift-ci-robot assigned LalatenduMohanty Sep 30, 2020

openshift-merge-robot merged commit 2c9d4a2 into openshift:master Oct 2, 2020

wking deleted the klog-v2 branch October 2, 2020 14:28

Bug 1883705: *: Move to klog v2 #462

Bug 1883705: *: Move to klog v2 #462

Uh oh!

Conversation

wking commented Sep 29, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

openshift-ci-robot commented Sep 29, 2020

Uh oh!

openshift-ci-robot commented Sep 29, 2020

Uh oh!

vrutkovs commented Sep 30, 2020

Uh oh!

vrutkovs left a comment

Choose a reason for hiding this comment

Uh oh!

oshoval left a comment

Choose a reason for hiding this comment

Uh oh!

vrutkovs commented Sep 30, 2020

Uh oh!

openshift-bot commented Sep 30, 2020

Uh oh!

LalatenduMohanty commented Sep 30, 2020

Uh oh!

openshift-ci-robot commented Sep 30, 2020

Uh oh!

openshift-bot commented Sep 30, 2020

Uh oh!

openshift-bot commented Sep 30, 2020

Uh oh!

openshift-bot commented Sep 30, 2020

Uh oh!

openshift-bot commented Sep 30, 2020

Uh oh!

openshift-bot commented Sep 30, 2020

Uh oh!

openshift-bot commented Sep 30, 2020

Uh oh!

wking commented Sep 30, 2020

Uh oh!

openshift-bot commented Sep 30, 2020

Uh oh!

wking commented Sep 30, 2020

Uh oh!

openshift-bot commented Sep 30, 2020

Uh oh!

openshift-bot commented Sep 30, 2020

Uh oh!

openshift-bot commented Oct 1, 2020

Uh oh!

openshift-bot commented Oct 1, 2020

Uh oh!

openshift-bot commented Oct 1, 2020

Uh oh!

openshift-bot commented Oct 1, 2020

Uh oh!

openshift-bot commented Oct 1, 2020

Uh oh!

openshift-bot commented Oct 1, 2020

Uh oh!

openshift-bot commented Oct 1, 2020

Uh oh!

openshift-bot commented Oct 1, 2020

Uh oh!

openshift-bot commented Oct 1, 2020

Uh oh!

openshift-bot commented Oct 1, 2020

Uh oh!

openshift-bot commented Oct 1, 2020

Uh oh!

openshift-bot commented Oct 1, 2020

Uh oh!

openshift-bot commented Oct 2, 2020

Uh oh!

openshift-bot commented Oct 2, 2020

Uh oh!

openshift-bot commented Oct 2, 2020

Uh oh!

openshift-bot commented Oct 2, 2020

wking commented Sep 29, 2020 •

edited

Loading