Skip to content

verify: Copy clientBuilder during cloning of a verifier #306

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
smarterclayton merged 1 commit into from
Jan 21, 2020
Merged

verify: Copy clientBuilder during cloning of a verifier #306

smarterclayton merged 1 commit into from
Jan 21, 2020

Conversation

@smarterclayton
Copy link
Contributor

@smarterclayton smarterclayton commented Jan 21, 2020

Otherwise clientBuilder is missing.

@smarterclayton
verify: Copy clientBuilder during cloning of a verifier
e144959 
Otherwise clientBuilder is missing.
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Jan 21, 2020

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: smarterclayton

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 21, 2020
@smarterclayton smarterclayton mentioned this pull request Jan 21, 2020
Merged
@openshift-ci-robot openshift-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jan 21, 2020
@smarterclayton smarterclayton mentioned this pull request Jan 21, 2020
Closed
@smarterclayton smarterclayton merged commit 268d89b into openshift:master Jan 21, 2020
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Jan 21, 2020

@smarterclayton: The following test failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
ci/prow/e2e-aws-upgrade e144959 link /test e2e-aws-upgrade

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@wking
Copy link
Member

wking commented Jan 21, 2020

This is another fix for #279

@wking wking mentioned this pull request Jan 21, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@crawford crawford Awaiting requested review from crawford

@wking wking Awaiting requested review from wking

Assignees

No one assigned

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@smarterclayton @openshift-ci-robot @wking