-
Notifications
You must be signed in to change notification settings - Fork 213
pkg/verify: Refactor signature fetching to only use a Store interface #294
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
pkg/verify: Refactor signature fetching to only use a Store interface #294
Conversation
97452c4 to
496b98f
Compare
|
e2e-aws had: /retest |
|
/cc @crawford PTAL |
|
@jottofar: GitHub didn't allow me to request PR reviews from the following users: PTAL. Note that only openshift members and repo collaborators can review this PR, and authors cannot review their own PRs. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
496b98f to
2bd263b
Compare
2bd263b to
7e02430
Compare
24d774f to
921f3ea
Compare
|
Rebased around #279 with 2bd263b -> 921f3ea, laying the groundwork for using this to address rhbz#1840343 (parallel HTTP(S) signature fetching). |
d1724ce to
487d860
Compare
This consolidates around abstract signature retrieval, removing the split between stores and locations which we grew in 9bbf366 (verify: Refactor the verify package to have common code, 2019-12-09, openshift#279). This will make it easier to make future changes like parallel HTTP(S) signature retrieval retrieval [1]. [1]: https://bugzilla.redhat.com/show_bug.cgi?id=1840343
487d860 to
6044c9c
Compare
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: wking The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
This abstracts signature retrieval, setting the stage for future pivots such as fetching signatures from config maps in the local cluster.
Spun off from these suggestions for #279. I've left the file implementation in place to minimize the diff (in 0cc3e41 I'd replaced it with an in-memory sig store). I've also left both the file and HTTP stores in the
verify.gofile to minimize the diff (in 0cc3e41 I'd moved the HTTP store into a subpackage to simplifyverify.go).