apiext: wait for CRD using v1beta1 for compatibility on upgrades #265
Conversation
openshift-ci-robot
added
the
size/XS
|
Context: This is softening 4ee7b07 (#259) to support the older v1beta1 types because 4.2->4.3 upgrades will load the 4.3 cluster-version operator before loading the 4.3 OpenShift API server. The 4.2 OpenShift API server doesn't support the v1 types, so the 4.3 CVO chokes and dies (example link?). With this PR, the 4.3 CVO will use the v1beta1 types that both 4.2 and 4.3 OpenShift API servers understand. Or something like that? |
This is softening 4ee7b07 (openshift#259) to use the older v1beta1 API version for waiting for CRDs to be established. This fixes the creation of v1beta1 CRDs before kube-apiserver is updated during a 4.2->4.3 update. Note: this will not fix the creation of v1 CRDs before kube-apiserver is upgraded. Hence, we are still restricted in the use of v1 CRDs for early manifests.
sttts
force-pushed
the
sttts-crd-v1-wait-v1beta1
branch
from
e621b9c to
42a0804
Compare
|
Looks good to me. Not sure if there's a way we can talk Prow into running 4.2->PR-tip CI on this... |
|
All green. I guess we'll just see about 4.2->4.3 once this gets built into the 4.3 images ;). /lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: sttts, wking The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci-robot
added
the
approved
4 participants
This is softening 4ee7b07 (#259) to use the older v1beta1 API version for waiting for CRDs to be established. This fixes the creation of v1beta1 CRDs before kube-apiserver is updated during a 4.2->4.3 update.
Note: this will not fix the creation of v1 CRDs before kube-apiserver is upgraded. Hence, we are still restricted in the use of v1 CRDs for early manifests.