Skip to content

Conversation

@jcpowermac
Copy link
Contributor

Updates to pull in proxy changes

Updates to pull in proxy changes
@openshift-ci-robot openshift-ci-robot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Jul 5, 2019
@jcpowermac
Copy link
Contributor Author

jcpowermac commented Jul 5, 2019

Needed for proxy changes:
#219

Not sure I did this right only updated api and client-go. If not let me know and I will fix.

@jcpowermac jcpowermac changed the title Update openshift client-go and api [wip] Update openshift client-go and api Jul 5, 2019
@openshift-ci-robot openshift-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jul 5, 2019
@jcpowermac jcpowermac changed the title [wip] Update openshift client-go and api Update openshift client-go and api Jul 5, 2019
@openshift-ci-robot openshift-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jul 5, 2019
@danehans
Copy link

danehans commented Jul 8, 2019

@abhinavdahiya PTAL

@abhinavdahiya
Copy link
Contributor

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Jul 8, 2019
@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: abhinavdahiya, jcpowermac

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 8, 2019
@openshift-merge-robot openshift-merge-robot merged commit a5f5007 into openshift:master Jul 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants