OCPBUGS-55937: Gate 4.19 -> 4.20 upgrade due to admissionregistration.k8s.io/v1beta1 API removal #1193

jacobsee · 2025-05-14T19:57:52Z

Add upgrade gate for the removal of admissionregistration.k8s.io/v1beta1 between 4.19 and 4.20.

…ta1 between 4.19 and 4.20.

benluddy · 2025-05-14T21:20:59Z

install/0000_00_cluster-version-operator_01_admingate_configmap.yaml

    include.release.openshift.io/self-managed-high-availability: "true"
+data:
+  ack-4.19-admissionregistration-v1beta1-api-removals-in-4.20: |-
+    The admissionregistration.k8s.io/v1beta1 API version is deprecated in 4.19 and will be removed in 4.20. The admissionregistration.k8s.io/v1 API versions of these resources are available for use in 4.19, and it is recommended to migrate to them before upgrading to 4.20.


Suggested change

The admissionregistration.k8s.io/v1beta1 API version is deprecated in 4.19 and will be removed in 4.20. The admissionregistration.k8s.io/v1 API versions of these resources are available for use in 4.19, and it is recommended to migrate to them before upgrading to 4.20.

The admissionregistration.k8s.io/v1beta1 API group version is deprecated and will be removed in 4.20. Clients must instead use the corresponding resources in the admissionregistration.k8s.io/v1 group version.

Nit: "Group version" is an appropriate term for this. Also, I don't know what the style conventions are for these messages, but stronger phrasing seems appropriate for the recommendation. Ignoring it means breaking any client that depends on the old GV.

jacobsee · 2025-05-16T21:33:11Z

/retest-required

openshift-ci-robot · 2025-06-20T21:26:40Z

@jacobsee: This pull request references Jira Issue OCPBUGS-57488, which is invalid:

expected the bug to target either version "4.19." or "openshift-4.19.", but it targets "4.18.z" instead
expected dependent Jira Issue OCPBUGS-55937 to target a version in 4.20.0, but it targets "4.19.z" instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

Add upgrade gate for the removal of admissionregistration.k8s.io/v1beta1 between 4.19 and 4.20.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

benluddy · 2025-06-23T13:21:37Z

/retitle OCPBUGS-55937: Gate 4.19 -> 4.20 upgrade due to admissionregistration.k8s.io/v1beta1 API removal

openshift-ci-robot · 2025-06-23T13:21:45Z

@jacobsee: This pull request references Jira Issue OCPBUGS-55937, which is invalid:

expected the bug to be in one of the following states: NEW, ASSIGNED, POST, but it is ON_QA instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

Add upgrade gate for the removal of admissionregistration.k8s.io/v1beta1 between 4.19 and 4.20.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

wangke19 · 2025-06-25T11:39:05Z

pre-merge tested the PR, looks good, detail see https://issues.redhat.com/browse/OCPBUGS-55937?focusedId=27478523&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-27478523

dgrisonnet · 2025-06-30T09:13:57Z

/lgtm
/retest

dgrisonnet · 2025-06-30T09:43:09Z

/jira refresh

openshift-ci-robot · 2025-06-30T09:43:16Z

@dgrisonnet: This pull request references Jira Issue OCPBUGS-55937, which is valid.

7 validation(s) were run on this bug

bug is open, matching expected state (open)
bug target version (4.19.z) matches configured target version for branch (4.19.z)
bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)
release note text is set and does not match the template
dependent bug Jira Issue OCPBUGS-55944 is in the state Verified, which is one of the valid states (VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA))
dependent Jira Issue OCPBUGS-55944 targets the "4.20.0" version, which is one of the valid target versions: 4.20.0
bug has dependents

Requesting review from QA contact:
/cc @wangke19

Details

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

jacobsee · 2025-07-03T23:02:43Z

/retest-required

dgrisonnet · 2025-07-08T12:30:32Z

/lgtm

wangke19 · 2025-07-11T03:40:54Z

/assign @wking
Needs approved, backport-risk-assessed labels from you. please.

jiajliu · 2025-07-15T07:53:33Z

cc @petr-muller and @PratikMahajan

wangke19 · 2025-07-21T11:48:48Z

Got suggesstion from https://redhat-internal.slack.com/archives/CF8SMALS1/p1752598604862809?thread_ts=1752564403.831279&cid=CF8SMALS1

This needs a KCS or other doc link to hold admin's hand through this removal, similar to what we've done for other Kube API server removals, e.g. https://github.com/openshift/cluster-version-operator/pull/1181/files#diff-f8697aadf7d50d34333c00c4fd526f096b9a65586fc4c086b330e7f10499056cR13

dinhxuanvu · 2025-08-07T13:40:38Z

@wking PTAL. Need your approval and backport-risk label. It seems this is PR to good to go unless I missed something. Feel free to correct me if that is the case.

benluddy · 2025-08-08T13:07:30Z

@wking PTAL. Need your approval and backport-risk label. It seems this is PR to good to go unless I missed something. Feel free to correct me if that is the case.

This one needs a link to a new KCS article before it can be approved.

jubittajohn · 2025-09-04T15:20:55Z

Attaching link to the draft KCS article here: https://access.redhat.com/articles/7130599
We could move forward with merging this PR in parallel while the KCS goes through review/publishing: slack thread: https://redhat-internal.slack.com/archives/C01CQA76KMX/p1756939754929839?thread_ts=1756933519.356519&cid=C01CQA76KMX
@wking could you PTAL and let us know if something more is required before we can try to get this PR in

wangke19 · 2025-09-16T12:31:00Z

/lgtm

wking

/lgtm
/retest-required

The KCS isn't published yet, but it's been through some review internally, and we're trying to prep for 4.20's coming GA. So merge this now, and we'll try and get the KCS out before whatever 4.19.z this ends up in goes GA.

openshift-ci · 2025-09-24T18:04:15Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dgrisonnet, jacobsee, wangke19, wking

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

~~OWNERS~~ [wking]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

wking · 2025-09-24T18:29:06Z

/label backport-risk-assessed

wking · 2025-09-24T20:28:22Z

Cluster Bot launch 4.19,openshift/cluster-version-operator#1193 azure (logs):

$ oc adm upgrade
Cluster version is 4.19.0-0-2025-09-24-191709-test-ci-ln-gs99jw2-latest

Upgradeable=False

  Reason: AdminAckRequired
  Message: The admissionregistration.k8s.io/v1beta1 group version is deprecated in 4.19 and will be removed in 4.20. Any clients using the v1beta1 version of these resources must be updated to use the corresponding v1 version instead. See https://access.redhat.com/articles/7130599 for more information.

warning: Cannot display available updates:
  Reason: NoChannel
  Message: The update channel has not been configured.
$ oc -n openshift-config patch cm admin-acks --patch '{"data":{"ack-4.19-admissionregistration-v1beta1-api-removals-in-4.20":"true"}}' --type=merge
configmap/admin-acks patched

Wait a few seconds for the CVO to notice and update status. Then:

$ oc adm upgrade
Cluster version is 4.19.0-0-2025-09-24-191709-test-ci-ln-gs99jw2-latest

warning: Cannot display available updates:
  Reason: NoChannel
  Message: The update channel has not been configured.

/verified by @wking

openshift-ci-robot · 2025-09-24T20:28:36Z

@wking: This PR has been marked as verified by @wking.

Details

In response to this:

Cluster Bot launch 4.19,openshift/cluster-version-operator#1193 azure (logs):

$ oc adm upgrade
Cluster version is 4.19.0-0-2025-09-24-191709-test-ci-ln-gs99jw2-latest

Upgradeable=False

 Reason: AdminAckRequired
 Message: The admissionregistration.k8s.io/v1beta1 group version is deprecated in 4.19 and will be removed in 4.20. Any clients using the v1beta1 version of these resources must be updated to use the corresponding v1 version instead. See https://access.redhat.com/articles/7130599 for more information.

warning: Cannot display available updates:
 Reason: NoChannel
 Message: The update channel has not been configured.
$ oc -n openshift-config patch cm admin-acks --patch '{"data":{"ack-4.19-admissionregistration-v1beta1-api-removals-in-4.20":"true"}}' --type=merge
configmap/admin-acks patched

Wait a few seconds for the CVO to notice and update status. Then:

$ oc adm upgrade
Cluster version is 4.19.0-0-2025-09-24-191709-test-ci-ln-gs99jw2-latest

warning: Cannot display available updates:
 Reason: NoChannel
 Message: The update channel has not been configured.

/verified by @wking

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

openshift-ci-robot · 2025-09-24T21:09:04Z

/retest-required

Remaining retests: 0 against base HEAD f165654 and 2 for PR HEAD faf7e27 in total

wking · 2025-09-24T21:10:59Z

node count should match or exceed machine count failed on a missing compute Node. Not sure what that's about. And I'm confident that this won't break that job, so I'm not waiting for the new run to wrap up.

/override ci/prow/e2e-agnostic-ovn-upgrade-into-change

openshift-ci · 2025-09-24T21:11:27Z

@wking: Overrode contexts on behalf of wking: ci/prow/e2e-agnostic-ovn-upgrade-into-change

Details

In response to this:

node count should match or exceed machine count failed on a missing compute Node. Not sure what that's about. And I'm confident that this won't break that job, so I'm not waiting for the new run to wrap up.

/override ci/prow/e2e-agnostic-ovn-upgrade-into-change

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

wking · 2025-09-24T21:24:34Z

Prow still grumpy about upgrade-into-change? Hammer again:

/override ci/prow/e2e-agnostic-ovn-upgrade-into-change

openshift-ci · 2025-09-24T21:24:51Z

@wking: Overrode contexts on behalf of wking: ci/prow/e2e-agnostic-ovn-upgrade-into-change

Details

In response to this:

Prow still grumpy about upgrade-into-change? Hammer again:

/override ci/prow/e2e-agnostic-ovn-upgrade-into-change

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

openshift-ci · 2025-09-24T21:24:52Z

@jacobsee: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/e2e-agnostic-operator-devpreview	`faf7e27`	link	false	`/test e2e-agnostic-operator-devpreview`
ci/prow/e2e-agnostic-ovn-upgrade-into-change	`faf7e27`	link	true	`/test e2e-agnostic-ovn-upgrade-into-change`

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

openshift-ci-robot · 2025-09-24T21:27:52Z

@jacobsee: Jira Issue OCPBUGS-55937: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-55937 has been moved to the MODIFIED state.

Details

In response to this:

Add upgrade gate for the removal of admissionregistration.k8s.io/v1beta1 between 4.19 and 4.20.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

jacobsee added 2 commits May 14, 2025 12:55

Add upgrade gate for the removal of admissionregistration.k8s.io/v1be…

ce8ad1b

…ta1 between 4.19 and 4.20.

group -> version

92f05f9

benluddy reviewed May 14, 2025

View reviewed changes

Strengthen language for recommendation

e849cad

jacobsee mentioned this pull request May 16, 2025

Gate 4.18 -> 4.20 upgrade due to admissionregistration.k8s.io/v1beta1 API removal #1194

Closed

jacobsee changed the title ~~Gate 4.19 -> 4.20 upgrade due to admissionregistration.k8s.io/v1beta1 API removal~~ OCPBUGS-57488: Gate 4.19 -> 4.20 upgrade due to admissionregistration.k8s.io/v1beta1 API removal Jun 20, 2025

openshift-ci-robot added jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Jun 20, 2025

openshift-ci bot changed the title ~~OCPBUGS-57488: Gate 4.19 -> 4.20 upgrade due to admissionregistration.k8s.io/v1beta1 API removal~~ OCPBUGS-55937: Gate 4.19 -> 4.20 upgrade due to admissionregistration.k8s.io/v1beta1 API removal Jun 23, 2025

openshift-ci bot assigned dgrisonnet Jun 30, 2025

openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jun 30, 2025

openshift-ci-robot added jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. and removed jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Jun 30, 2025

openshift-ci bot requested a review from wangke19 June 30, 2025 09:43

Phrasing update from "migrate" to "update"

9930d86

openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Jul 2, 2025

openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jul 8, 2025

openshift-ci bot assigned wking Jul 11, 2025

wking mentioned this pull request Jul 22, 2025

CNTRLPLANE-1110: Issue HCPServiceHealthCheckDisruption for 4.18 -> 4.19.[0-4] openshift/cincinnati-graph-data#7619

Merged

wangke19 mentioned this pull request Aug 15, 2025

[release-4.18] OCPBUGS-57488: UPSTREAM: <carry>: Mark admissionregistration.k8s.io/v1beta1 as deprecated. openshift/kubernetes#2333

Merged

Add link to article

faf7e27

openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Sep 16, 2025

openshift-ci bot assigned wangke19 Sep 16, 2025

openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Sep 16, 2025

wking approved these changes Sep 24, 2025

View reviewed changes

openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 24, 2025

openshift-ci bot added the backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. label Sep 24, 2025

openshift-ci-robot added the verified Signifies that the PR passed pre-merge verification criteria label Sep 24, 2025

openshift-merge-bot bot merged commit 810c159 into openshift:release-4.19 Sep 24, 2025
13 of 14 checks passed

	The admissionregistration.k8s.io/v1beta1 API version is deprecated in 4.19 and will be removed in 4.20. The admissionregistration.k8s.io/v1 API versions of these resources are available for use in 4.19, and it is recommended to migrate to them before upgrading to 4.20.
	The admissionregistration.k8s.io/v1beta1 API group version is deprecated and will be removed in 4.20. Clients must instead use the corresponding resources in the admissionregistration.k8s.io/v1 group version.

OCPBUGS-55937: Gate 4.19 -> 4.20 upgrade due to admissionregistration.k8s.io/v1beta1 API removal #1193

OCPBUGS-55937: Gate 4.19 -> 4.20 upgrade due to admissionregistration.k8s.io/v1beta1 API removal #1193

Uh oh!

Conversation

jacobsee commented May 14, 2025

Uh oh!

benluddy May 14, 2025

Choose a reason for hiding this comment

Uh oh!

jacobsee commented May 16, 2025

Uh oh!

openshift-ci-robot commented Jun 20, 2025

Uh oh!

benluddy commented Jun 23, 2025

Uh oh!

openshift-ci-robot commented Jun 23, 2025

Uh oh!

wangke19 commented Jun 25, 2025

Uh oh!

dgrisonnet commented Jun 30, 2025

Uh oh!

dgrisonnet commented Jun 30, 2025

Uh oh!

openshift-ci-robot commented Jun 30, 2025

Uh oh!

jacobsee commented Jul 3, 2025

Uh oh!

dgrisonnet commented Jul 8, 2025

Uh oh!

wangke19 commented Jul 11, 2025

Uh oh!

jiajliu commented Jul 15, 2025

Uh oh!

wangke19 commented Jul 21, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

dinhxuanvu commented Aug 7, 2025

Uh oh!

benluddy commented Aug 8, 2025

Uh oh!

jubittajohn commented Sep 4, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

wangke19 commented Sep 16, 2025

Uh oh!

wking left a comment

Choose a reason for hiding this comment

Uh oh!

openshift-ci bot commented Sep 24, 2025

Uh oh!

wking commented Sep 24, 2025

Uh oh!

wking commented Sep 24, 2025

Uh oh!

openshift-ci-robot commented Sep 24, 2025

Uh oh!

openshift-ci-robot commented Sep 24, 2025

Uh oh!

wking commented Sep 24, 2025

Uh oh!

openshift-ci bot commented Sep 24, 2025

Uh oh!

wking commented Sep 24, 2025

Uh oh!

openshift-ci bot commented Sep 24, 2025

Uh oh!

openshift-ci bot commented Sep 24, 2025

Uh oh!

Uh oh!

openshift-ci-robot commented Sep 24, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

9 participants

wangke19 commented Jul 21, 2025 •

edited

Loading

jubittajohn commented Sep 4, 2025 •

edited

Loading