Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @wking as per the doc link https://access.redhat.com/articles/7112216,
bit confused over the statements, and i dont see in doc that the acknowledgement is required.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice catch! It's @bergerhoffer 's KCS, and she's said she can have it updated and published by Wednesday the 30th, when the next 4.18.z that might consume this will be built. So I think we can merge as it stands, and have the KCS updated to call out the need for an ack by the time customers might be running clusters with the gate.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
KCS is updated to reflect that there is actually going to be an admin-ack this time. Once this PR merges and we know what z-stream it'll be in, I'll update the KCS with that value and publish.