Skip to content

NO-JIRA: task graph: test speedup and code cleaup #1101

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
openshift-merge-bot merged 2 commits into from
Nov 5, 2024
Merged

NO-JIRA: task graph: test speedup and code cleaup #1101

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1c71a50
task graph test: do not wait after cancelation
petr-muller Oct 30, 2024
df39a81
task graph: simplify code
petr-muller Oct 30, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion pkg/payload/task_graph_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -949,7 +949,6 @@ func TestRunGraph(t *testing.T) {
callbacks: map[string]callbackFn{
"a": func(t *testing.T, name string, ctx context.Context, cancelFn func()) error {
cancelFn()
time.Sleep(time.Second)

@wking wking Nov 4, 2024

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd added this with the test-case back in eaa3d19 (#255). I didn't talk about the Sleep specifically in the commit message, but my guess is that what I was aiming for was "make sure b isn't running because the task-graph runner knows a failed" to avoid "b would have run, except the runner got lucky and raced closed before it got around to completing". It's been in place for a long time now though, and I'm fine dropping the "be-extra certain" sleep at this point in order to allow us to run tests more quickly.

return nil
},
"*": func(t *testing.T, name string, ctx context.Context, cancelFn func()) error {
Expand Down