Skip to content

Comments

no-jira: TestCVO: set known caps from configv1.KnownClusterVersionCapabilities#1075

Merged
openshift-merge-bot[bot] merged 1 commit intoopenshift:masterfrom
ingvagabund:test-cvo-set-known-caps-from-configv1.KnownClusterVersionCapabilities
Jul 25, 2024
Merged

no-jira: TestCVO: set known caps from configv1.KnownClusterVersionCapabilities#1075
openshift-merge-bot[bot] merged 1 commit intoopenshift:masterfrom
ingvagabund:test-cvo-set-known-caps-from-configv1.KnownClusterVersionCapabilities

Conversation

@ingvagabund
Copy link
Member

@ingvagabund ingvagabund commented Jul 25, 2024

KnownClusterVersionCapabilities is the referential list of known capabilities. ClusterVersionCapabilitySetCurrent/DefaultCapabilitySet can change in time. As in openshift/api#1954.

To unblock #1066.

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Jul 25, 2024
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Jul 25, 2024

@ingvagabund: This pull request explicitly references no jira issue.

Details

In response to this:

KnownClusterVersionCapabilities is the referential list of known capabilities. ClusterVersionCapabilitySetCurrent/DefaultCapabilitySet can change in time. As in openshift/api#1954.

To unblock #1066.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@ingvagabund ingvagabund force-pushed the test-cvo-set-known-caps-from-configv1.KnownClusterVersionCapabilities branch from 258e1e4 to ea377b0 Compare July 25, 2024 09:21
@openshift-ci openshift-ci bot requested review from DavidHurta and petr-muller July 25, 2024 09:21
@ingvagabund ingvagabund force-pushed the test-cvo-set-known-caps-from-configv1.KnownClusterVersionCapabilities branch from ea377b0 to d3687b5 Compare July 25, 2024 09:23
@ingvagabund ingvagabund changed the title no-jira: Test cvo set known caps from configv1.known cluster version capabilities no-jira: TestCvo: set known caps from configv1.known cluster version capabilities Jul 25, 2024
@ingvagabund ingvagabund changed the title no-jira: TestCvo: set known caps from configv1.known cluster version capabilities no-jira: TestCVO: set known caps from configv1.known cluster version capabilities Jul 25, 2024
@ingvagabund ingvagabund changed the title no-jira: TestCVO: set known caps from configv1.known cluster version capabilities no-jira: TestCVO: set known caps from configv1.KnownClusterVersionCapabilities Jul 25, 2024
@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jul 25, 2024
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jul 25, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ingvagabund, petr-muller

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 25, 2024
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jul 25, 2024

@ingvagabund: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@ingvagabund
Copy link
Member Author

ingvagabund commented Jul 25, 2024

/label no-qe

Unit test change only, no pre-merge testing needed

@openshift-ci openshift-ci bot added the no-qe Allows PRs to merge without qe-approved label label Jul 25, 2024
@openshift-merge-bot openshift-merge-bot bot merged commit a80fe4e into openshift:master Jul 25, 2024
@ingvagabund ingvagabund deleted the test-cvo-set-known-caps-from-configv1.KnownClusterVersionCapabilities branch July 25, 2024 12:10
@openshift-bot
Copy link
Contributor

openshift-bot commented Jul 25, 2024

[ART PR BUILD NOTIFIER]

Distgit: cluster-version-operator
This PR has been included in build cluster-version-operator-container-v4.17.0-202407251411.p0.ga80fe4e.assembly.stream.el9.
All builds following this will include this PR.

@hongkailiu hongkailiu mentioned this pull request Oct 29, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@DavidHurta DavidHurta Awaiting requested review from DavidHurta

1 more reviewer

@petr-muller petr-muller petr-muller approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@petr-muller petr-muller

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. no-qe Allows PRs to merge without qe-approved label

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@ingvagabund @openshift-ci-robot @openshift-bot @petr-muller