Skip to content

WIP: PromQL result debugging #1010

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wking wants to merge 1 commit into from
Closed

WIP: PromQL result debugging #1010

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions pkg/clusterconditions/promql/promql.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -172,6 +172,7 @@ func (p *PromQL) Match(ctx context.Context, condition *configv1.ClusterCondition
if err != nil {
return false, fmt.Errorf("executing PromQL query: %w", err)
}
klog.V(2).Infof("DEBUG: evaluated %s cluster condition: %q:\n%v\n%v", condition.Type, condition.PromQL.PromQL, result, warnings)

for _, warning := range warnings {
klog.Warning(warning)
Expand All @@ -189,6 +190,7 @@ func (p *PromQL) Match(ctx context.Context, condition *configv1.ClusterCondition
if vector.Len() != 1 {
return false, fmt.Errorf("invalid PromQL result length must be one, but is %d", vector.Len())
}
klog.V(2).Infof("DEBUG: evaluated %s cluster condition: %q: vector length %d", condition.Type, condition.PromQL.PromQL, vector.Len())

sample := vector[0]
if sample.Value == 0 {
Expand Down