Add Proxy CA support #49
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
openshift-ci-robot
added
size/M
openshift-ci-robot
added
size/L
danehans
reviewed
Aug 14, 2019
danehans
reviewed
Aug 14, 2019
danehans
left a comment
danehans
left a comment
There was a problem hiding this comment.
One nit #49 (comment). Otherwise lgtm.
joelanford
requested changes
Aug 14, 2019
Member
joelanford
left a comment
joelanford
left a comment
There was a problem hiding this comment.
A few tweaks and nits, and I think this will be good to go.
Contributor
Author
|
Waiting on openshift/cluster-network-operator#271 /hold |
openshift-ci-robot
added
the
do-not-merge/hold
jmrodri
force-pushed
the
add-ca-support
branch
from
a3c3a67 to
b698c0b
Compare
Contributor
Author
|
@danehans @joelanford comments have been addressed. PR updated. |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: danehans, jmrodri The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Member
|
/retest |
Contributor
Author
|
/unhold |
Contributor
Author
|
/hold cancel |
openshift-ci-robot
removed
the
do-not-merge/hold
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.