STOR-1767: add env var OPERATOR_NAME to vsphere csi operator deployment

[mpatlasov]

openshift/vmware-vsphere-csi-driver-operator#233 will do allowOperatorRemovedState=True for vsphere csi operator. This will trigger finalazer check in library-go:

	if management.IsOperatorRemovable() {
		if err := v1helpers.EnsureFinalizer(ctx, c.operatorClient, c.name); err != nil {

EnsureFinalizer(), in turn, calculates finalizer name either as os.Getenv("OPERATOR_NAME") or os.Args[0]. The latter doesn't work for vsphere because leading slash in /usr/bin/vmware-vsphere-csi-driver-operator is not allowed:

E0701 19:43:32.342151       1 base_controller.go:268] VMwareVSphereDriverControllerServiceController reconciliation failed: ClusterCSIDriver.operator.openshift.io "csi.vsphere.vmware.com" is invalid: metadata.finalizers: Invalid value: "/usr/bin/vmware-vsphere-csi-driver-operator.operator.openshift.io/VMwareVSphereDriverControllerServiceController": a qualified name must consist of alphanumeric characters, '-', '_' or '.', and must start and end with an alphanumeric character (e.g. 'MyName',  or 'my.name',  or '123-abc', regex used for validation is '([A-Za-z0-9][-A-Za-z0-9_.]*)?[A-Za-z0-9]') with an optional DNS subdomain prefix and '/' (e.g. 'example.com/MyName')

[openshift-ci-robot]

@mpatlasov: This pull request references STOR-1767 which is a valid jira issue.

Details

In response to this:

openshift/vmware-vsphere-csi-driver-operator#233 will do allowOperatorRemovedState=True for vsphere csi operator. This will trigger finalazer check in library-go:

  if management.IsOperatorRemovable() {
  	if err := v1helpers.EnsureFinalizer(ctx, c.operatorClient, c.name); err != nil {

EnsureFinalizer(), in turn, calculates finalizer name either as os.Getenv("OPERATOR_NAME") or os.Args[0]. The latter doesn't work for vsphere because leading slash in /usr/bin/vmware-vsphere-csi-driver-operator is not allowed:

E0701 19:43:32.342151       1 base_controller.go:268] VMwareVSphereDriverControllerServiceController reconciliation failed: ClusterCSIDriver.operator.openshift.io "csi.vsphere.vmware.com" is invalid: metadata.finalizers: Invalid value: "/usr/bin/vmware-vsphere-csi-driver-operator.operator.openshift.io/VMwareVSphereDriverControllerServiceController": a qualified name must consist of alphanumeric characters, '-', '_' or '.', and must start and end with an alphanumeric character (e.g. 'MyName',  or 'my.name',  or '123-abc', regex used for validation is '([A-Za-z0-9][-A-Za-z0-9_.]*)?[A-Za-z0-9]') with an optional DNS subdomain prefix and '/' (e.g. 'example.com/MyName')

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mpatlasov

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• OWNERS [mpatlasov]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[openshift-ci]

@mpatlasov: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/e2e-openstack	c529a03	link	false	/test e2e-openstack
ci/prow/e2e-ibmcloud-csi	c529a03	link	false	/test e2e-ibmcloud-csi

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

[dobsonj]

/lgtm

[mpatlasov]

/label docs-approved
/label px-approved

[mpatlasov]

/label no-qe

[openshift-ci]

@mpatlasov: The label(s) no-qe cannot be applied, because the repository doesn't have them.

Details

In response to this:

/label no-qe

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[duanwei33]

/label qe-approved

[openshift-ci-robot]

@mpatlasov: This pull request references STOR-1767 which is a valid jira issue.

Details

In response to this:

openshift/vmware-vsphere-csi-driver-operator#233 will do allowOperatorRemovedState=True for vsphere csi operator. This will trigger finalazer check in library-go:

  if management.IsOperatorRemovable() {
  	if err := v1helpers.EnsureFinalizer(ctx, c.operatorClient, c.name); err != nil {

EnsureFinalizer(), in turn, calculates finalizer name either as os.Getenv("OPERATOR_NAME") or os.Args[0]. The latter doesn't work for vsphere because leading slash in /usr/bin/vmware-vsphere-csi-driver-operator is not allowed:

E0701 19:43:32.342151       1 base_controller.go:268] VMwareVSphereDriverControllerServiceController reconciliation failed: ClusterCSIDriver.operator.openshift.io "csi.vsphere.vmware.com" is invalid: metadata.finalizers: Invalid value: "/usr/bin/vmware-vsphere-csi-driver-operator.operator.openshift.io/VMwareVSphereDriverControllerServiceController": a qualified name must consist of alphanumeric characters, '-', '_' or '.', and must start and end with an alphanumeric character (e.g. 'MyName',  or 'my.name',  or '123-abc', regex used for validation is '([A-Za-z0-9][-A-Za-z0-9_.]*)?[A-Za-z0-9]') with an optional DNS subdomain prefix and '/' (e.g. 'example.com/MyName')

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[openshift-bot]

[ART PR BUILD NOTIFIER]

This PR has been included in build ose-cluster-storage-operator-container-v4.17.0-202407030818.p0.g5c50083.assembly.stream.el9 for distgit cluster-storage-operator.
All builds following this will include this PR.