Skip to content

STOR-1804: update ClusterCSIDriver CRDs#464

Merged
openshift-merge-bot[bot] merged 2 commits intoopenshift:masterfrom
RomanBednar:driver-config
Apr 18, 2024
Merged

STOR-1804: update ClusterCSIDriver CRDs#464
openshift-merge-bot[bot] merged 2 commits intoopenshift:masterfrom
RomanBednar:driver-config

Conversation

@RomanBednar
Copy link
Contributor

@RomanBednar RomanBednar commented Mar 11, 2024

No description provided.

@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Mar 11, 2024
@openshift-ci openshift-ci bot requested review from bertinatto and tsmetana March 11, 2024 12:39
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Mar 11, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: RomanBednar

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 11, 2024
@RomanBednar RomanBednar force-pushed the driver-config branch 6 times, most recently from 839d90f to 6809701 Compare March 14, 2024 16:05
@RomanBednar RomanBednar mentioned this pull request Mar 15, 2024
Merged
@RomanBednar RomanBednar force-pushed the driver-config branch 2 times, most recently from b1731da to 792913d Compare April 5, 2024 15:41
@RomanBednar RomanBednar changed the title WIP: separate ClusterCSIDriver CRDs for tech preview WIP: STOR-1804: separate ClusterCSIDriver CRDs for tech preview Apr 8, 2024
@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Apr 8, 2024
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Apr 8, 2024 •
edited by openshift-ci bot
Loading

@RomanBednar: This pull request references STOR-1804 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.16.0" version, but no target version was set.

Details

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@RomanBednar RomanBednar changed the title WIP: STOR-1804: separate ClusterCSIDriver CRDs for tech preview WIP: STOR-1804: update ClusterCSIDriver CRDs Apr 9, 2024
@RomanBednar RomanBednar force-pushed the driver-config branch 2 times, most recently from a722aaf to 4901762 Compare April 16, 2024 06:33
@RomanBednar RomanBednar changed the title WIP: STOR-1804: update ClusterCSIDriver CRDs STOR-1804: update ClusterCSIDriver CRDs Apr 16, 2024
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Apr 16, 2024
jsafrane
jsafrane reviewed Apr 16, 2024
View reviewed changes
@RomanBednar
bump openshif/api and import crd manifests for vendoring
70f21f9 
CRD manifest are no longer vendored implicitly when go.mod references
openshift/api. Adding import to dependencymagnet.go.

The manifests are required for image builds (see Dockerfile and
Dockerfile.rhel7) and get copied to /manifests dir on build time.
@RomanBednar
update CRD manifest paths in vendor
ab1a6aa 
When using tech preview fields in openshift/api multiple manifests are
generated that we need to import.

Also the path to storage CRD changed.
@jsafrane
Copy link
Contributor

jsafrane commented Apr 16, 2024

/lgtm
/retest-required

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Apr 16, 2024
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Apr 16, 2024

@RomanBednar: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-ibmcloud-csi ab1a6aa link false /test e2e-ibmcloud-csi
ci/prow/e2e-gcp-manual-oidc ab1a6aa link false /test e2e-gcp-manual-oidc

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@RomanBednar
Copy link
Contributor Author

RomanBednar commented Apr 18, 2024

/label px-approved
/label docs-approved

@openshift-ci openshift-ci bot added px-approved Signifies that Product Support has signed off on this PR docs-approved Signifies that Docs has signed off on this PR labels Apr 18, 2024
@Phaow
Copy link
Contributor

Phaow commented Apr 18, 2024

/label qe-approved
Pre verify passed with 4.16.0-0.test-2024-04-08-003725-ci-ln-sv9g1z2-latest (build 4.16.0-0.ci,openshift/api#1783,openshift/vmware-vsphere-csi-driver-operator#226,#464)

@openshift-ci openshift-ci bot added the qe-approved Signifies that QE has signed off on this PR label Apr 18, 2024
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Apr 18, 2024 •
edited by openshift-ci bot
Loading

@RomanBednar: This pull request references STOR-1804 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.16.0" version, but no target version was set.

Details

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-merge-bot openshift-merge-bot bot merged commit 233eb29 into openshift:master Apr 18, 2024
@openshift-bot
Copy link
Contributor

openshift-bot commented Apr 18, 2024

[ART PR BUILD NOTIFIER]

This PR has been included in build ose-cluster-storage-operator-container-v4.16.0-202404181209.p0.g233eb29.assembly.stream.el9 for distgit cluster-storage-operator.
All builds following this will include this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jsafrane jsafrane jsafrane left review comments

@bertinatto bertinatto Awaiting requested review from bertinatto

@tsmetana tsmetana Awaiting requested review from tsmetana

Assignees

@jsafrane jsafrane

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. docs-approved Signifies that Docs has signed off on this PR jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. px-approved Signifies that Product Support has signed off on this PR qe-approved Signifies that QE has signed off on this PR

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@RomanBednar @openshift-ci-robot @jsafrane @Phaow @openshift-bot

Comments