Skip to content

OCPBUGS-18132: Add patch for allowing configmap updates via clusterrole#396

Merged
openshift-merge-robot merged 2 commits intoopenshift:release-4.13from
gnufied:add-update-patch-perms-for-vsphere
Sep 26, 2023
Merged

OCPBUGS-18132: Add patch for allowing configmap updates via clusterrole#396
openshift-merge-robot merged 2 commits intoopenshift:release-4.13from
gnufied:add-update-patch-perms-for-vsphere

Conversation

@gnufied
Copy link
Member

@gnufied gnufied commented Sep 10, 2023 •
edited
Loading

Goes with openshift/vmware-vsphere-csi-driver-operator#169

Fixes OCPBUGS-18132

@openshift-ci openshift-ci bot requested review from dobsonj and jsafrane September 10, 2023 13:57
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Sep 10, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: gnufied

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 10, 2023
jsafrane
jsafrane reviewed Sep 11, 2023
View reviewed changes
assets/csidriveroperators/vsphere/06_clusterrole.yaml Outdated
Comment on lines 312 to 313
- patch
- update
Copy link
Contributor

@jsafrane jsafrane Sep 11, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This allows the vSphere CSI driver operator to patch any pod and ConfigMap in any namespace. IMO it's too broad.
It should allow only selected ConfigMap in openshift-config-managed namespace, i.e. a Role could be better. And definitely decoupled from Pods.

Copy link
Member Author

@gnufied gnufied Sep 11, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Moved this to use named configmap. I think that works as well. I am not sure how a role will work, unless we create one in openshift-config-managed namespace.

@gnufied gnufied changed the title Add patch for allowing configmap updates via clusterrole OCPBUGS-18132: Add patch for allowing configmap updates via clusterrole Sep 11, 2023
@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Sep 11, 2023
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Sep 11, 2023

@gnufied: This pull request references Jira Issue OCPBUGS-18132, which is invalid:

  • expected the bug to target the "4.13.z" version, but no target version was set
  • expected Jira Issue OCPBUGS-18132 to depend on a bug targeting a version in 4.14.0 and in one of the following states: VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), but no dependents were found

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

Goes with openshift/vmware-vsphere-csi-driver-operator#169

Fixes OCPBUGS-18132

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added the jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. label Sep 11, 2023
@gnufied
Copy link
Member Author

gnufied commented Sep 11, 2023

/jira refresh

@openshift-ci-robot openshift-ci-robot added jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. and removed jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Sep 11, 2023
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Sep 11, 2023

@gnufied: This pull request references Jira Issue OCPBUGS-18132, which is valid.

6 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.13.z) matches configured target version for branch (4.13.z)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)
  • dependent bug Jira Issue OCPBUGS-18797 is in the state Closed (Done), which is one of the valid states (VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE))
  • dependent Jira Issue OCPBUGS-18797 targets the "4.14.0" version, which is one of the valid target versions: 4.14.0
  • bug has dependents
Details

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@jsafrane
Copy link
Contributor

jsafrane commented Sep 12, 2023

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Sep 12, 2023
@jsafrane
Copy link
Contributor

jsafrane commented Sep 13, 2023

/label backport-risk-assessed

@openshift-ci openshift-ci bot added the backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. label Sep 13, 2023
@duanwei33 duanwei33 mentioned this pull request Sep 25, 2023
Merged
@duanwei33
Copy link

duanwei33 commented Sep 26, 2023

See test on openshift/vmware-vsphere-csi-driver-operator#169.

@duanwei33
Copy link

duanwei33 commented Sep 26, 2023

/label qe-approved
/label cherry-pick-approved

@openshift-ci openshift-ci bot added qe-approved Signifies that QE has signed off on this PR cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. labels Sep 26, 2023
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Sep 26, 2023

/retest-required

Remaining retests: 0 against base HEAD 37cc945 and 2 for PR HEAD e4911f3 in total

@gnufied
Copy link
Member Author

gnufied commented Sep 26, 2023

/cherry-pick release-4.12

@openshift-cherrypick-robot
Copy link

openshift-cherrypick-robot commented Sep 26, 2023

@gnufied: once the present PR merges, I will cherry-pick it on top of release-4.12 in a new PR and assign it to you.

Details

In response to this:

/cherry-pick release-4.12

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@gnufied
Copy link
Member Author

gnufied commented Sep 26, 2023

/retest-required

@gnufied
Copy link
Member Author

gnufied commented Sep 26, 2023

/retest

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Sep 26, 2023

@gnufied: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-merge-robot openshift-merge-robot merged commit 6769015 into openshift:release-4.13 Sep 26, 2023
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Sep 26, 2023

@gnufied: Jira Issue OCPBUGS-18132: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-18132 has been moved to the MODIFIED state.

Details

In response to this:

Goes with openshift/vmware-vsphere-csi-driver-operator#169

Fixes OCPBUGS-18132

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Sep 26, 2023
Merged
@openshift-cherrypick-robot
Copy link

openshift-cherrypick-robot commented Sep 26, 2023

@gnufied: new pull request created: #402

Details

In response to this:

/cherry-pick release-4.12

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-merge-robot
Copy link
Contributor

openshift-merge-robot commented Sep 28, 2023

Fix included in accepted release 4.13.0-0.nightly-2023-09-27-193040

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jsafrane jsafrane jsafrane left review comments

@dobsonj dobsonj Awaiting requested review from dobsonj

Assignees

@jsafrane jsafrane

@chao007 chao007

@duanwei33 duanwei33

@ropatil010 ropatil010

@Phaow Phaow

@radeore radeore

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. qe-approved Signifies that QE has signed off on this PR

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

10 participants

@gnufied @openshift-ci-robot @jsafrane @duanwei33 @openshift-cherrypick-robot @openshift-merge-robot @chao007 @ropatil010 @Phaow @radeore