Skip to content

Comments

Revert "update storage operator to read featuregates from API on standalone OCP"#375

Merged
openshift-merge-robot merged 1 commit intoopenshift:masterfrom
stbenjam:revert-368-feature-gates
May 30, 2023
Merged

Revert "update storage operator to read featuregates from API on standalone OCP"#375
openshift-merge-robot merged 1 commit intoopenshift:masterfrom
stbenjam:revert-368-feature-gates

Conversation

@stbenjam
Copy link
Member

@stbenjam stbenjam commented May 30, 2023

Reverts #368, tracked by TRT-1059

Per OpenShift policy, we are reverting this breaking change to get CI and/or nightly payloads flowing again.

cluster-storage-operator is panicking on hypershift. See #368 (comment) for more details.

To unrevert this, revert this PR, and layer an additional separate commit on top that addresses the problem. Before merging the unrevert, please run the hypershift job on the PR and check the result of hypershift presubmit to confirm the fix has corrected the problem.

CC: @deads2k, @sjenning, @jsafrane

@openshift-ci openshift-ci bot requested review from dobsonj and gnufied May 30, 2023 10:13
@openshift-ci
Copy link
Contributor

openshift-ci bot commented May 30, 2023

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: stbenjam
Once this PR has been reviewed and has the lgtm label, please assign dobsonj for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@stbenjam
Copy link
Member Author

stbenjam commented May 30, 2023

/skip
/override ci/prow/e2e-aws-ovn
/override ci/prow/e2e-aws-ovn-upgrade
/override ci/prow/e2e-gcp-ovn

This is a clean revert of the most recent commit, we're returning to a previously tested state. Forcing this

@neisw
Copy link

neisw commented May 30, 2023

/lgtm

@openshift-ci
Copy link
Contributor

openshift-ci bot commented May 30, 2023

@stbenjam: Overrode contexts on behalf of stbenjam: ci/prow/e2e-aws-ovn, ci/prow/e2e-aws-ovn-upgrade, ci/prow/e2e-gcp-ovn

Details

In response to this:

/skip
/override ci/prow/e2e-aws-ovn
/override ci/prow/e2e-aws-ovn-upgrade
/override ci/prow/e2e-gcp-ovn

This is a clean revert of the most recent commit, we're returning to a previously tested state for forcing this

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label May 30, 2023
@stbenjam
Copy link
Member Author

/label approved

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 30, 2023
@stbenjam
Copy link
Member Author

/label jira/valid-bug

@openshift-ci openshift-ci bot added the jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. label May 30, 2023
@openshift-merge-robot openshift-merge-robot merged commit 86fc510 into openshift:master May 30, 2023
@stbenjam stbenjam deleted the revert-368-feature-gates branch May 30, 2023 12:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants