feat: library-go bump#244
Conversation
openshift-ci
Bot
added
the
do-not-merge/work-in-progress
|
/retest |
bertinatto
left a comment
bertinatto
left a comment
There was a problem hiding this comment.
Our CSI sidexar containers also use the default leader election values provided in library-go:
Do we need to update those as well?
| } | ||
|
|
||
| _, _, err := v1helpers.UpdateStatus(c.operatorClient, | ||
| _, _, err := v1helpers.UpdateStatus(context.TODO(), c.operatorClient, |
There was a problem hiding this comment.
Could you split these changes into a separate commit?
There was a problem hiding this comment.
Also, please use the context variable from the parent function (you will need to plumb it through).
There was a problem hiding this comment.
Absolutely, updated with recommendations.
There was a problem hiding this comment.
I did go ahead and modify other places I was using TODO to grab from the parent as well, if that's not something you're looking for I can revert it back
| return err | ||
| } | ||
| _, _, err := v1helpers.UpdateStatus(c.operatorClient, | ||
| _, _, err := v1helpers.UpdateStatus(context.TODO(), c.operatorClient, |
There was a problem hiding this comment.
Same comment about the context.
Signed-off-by: ehila <ehila@redhat.com>
Signed-off-by: ehila <ehila@redhat.com>
eggfoobar
force-pushed
the
library_go_bump
branch
from
c2c4ccc to
93a8f24
Compare
openshift-ci
Bot
removed
the
do-not-merge/work-in-progress
Signed-off-by: ehila <ehila@redhat.com>
eggfoobar
force-pushed
the
library_go_bump
branch
from
93a8f24 to
9f2a2a9
Compare
|
@eggfoobar: The following tests failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
| pflag.CommandLine.AddGoFlagSet(flag.CommandLine) | ||
|
|
||
| logs.InitLogs() | ||
| logs.AddFlags(pflag.CommandLine) |
There was a problem hiding this comment.
Please check this PR for an example of how this should look like: openshift/cluster-kube-controller-manager-operator@c339a94
There was a problem hiding this comment.
Oh that's way better, thank you, updated :)
Signed-off-by: ehila <ehila@redhat.com>
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: bertinatto, eggfoobar The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
Bot
added
the
approved
4 participants
Bumping the library-go dependency to latest, this should take advantage of leader election changes for SNO clusters proposed in this library-go PR and performance improvements in this PR.
Changes:
Signed-off-by: ehila ehila@redhat.com