Bug 1948505: Add missing RBAC rules for vSphere #156

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merged

openshift-merge-robot merged 1 commit into openshift:master from bertinatto:fix-vsphere-proxy

Apr 17, 2021

Member

bertinatto commented Apr 13, 2021

The operator needs to watch the proxies resource and update the clustercsidriver's spec. This patch adds the missing RBAC rules that allow those actions.

Similar PRs for other operators:

CC @openshift/storage


          Add missing RBAC rules for vSphere.

0612ea4

The operator needs to watch the proxies resource
and update the clustercsidriver's spec. This patch
adds the missing RBAC rules that allow those actions.

openshift-ci-robot added the bugzilla/severity-high label

Contributor

openshift-ci-robot commented Apr 13, 2021

@bertinatto: This pull request references Bugzilla bug 1948505, which is invalid:

expected the bug to target the "4.8.0" release, but it targets "---" instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

Details

In response to this:

Bug 1948505: Add missing RBAC rules for vSphere

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci-robot added the bugzilla/invalid-bug label

openshift-ci-robot requested review from gnufied and tsmetana

April 13, 2021 10:42

openshift-ci-robot added the approved label

Member Author

bertinatto commented Apr 13, 2021

/bugzilla refresh

openshift-ci-robot added bugzilla/valid-bug and removed bugzilla/invalid-bug labels

Contributor

openshift-ci-robot commented Apr 13, 2021

@bertinatto: This pull request references Bugzilla bug 1948505, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug

bug is open, matching expected state (open)
bug target release (4.8.0) matches configured target release for branch (4.8.0)
bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

No GitHub users were found matching the public email listed for the QA contact in Bugzilla ([email protected]), skipping review request.

Details

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Member Author

bertinatto commented Apr 13, 2021

/test e2e-aws

Member Author

bertinatto commented Apr 13, 2021

/test e2e-aws-upgrade

Member

gnufied commented Apr 13, 2021

/lgtm

openshift-ci-robot assigned gnufied

openshift-ci-robot added the lgtm label

Contributor

openshift-ci-robot commented Apr 13, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bertinatto, gnufied

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

~~OWNERS~~ [bertinatto,gnufied]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Contributor

openshift-bot commented Apr 13, 2021

/retest

Please review the full test history for this PR and help us cut down flakes.

12 similar comments

Contributor

openshift-bot commented Apr 13, 2021

/retest

Please review the full test history for this PR and help us cut down flakes.

Contributor

openshift-bot commented Apr 13, 2021

/retest

Please review the full test history for this PR and help us cut down flakes.

Contributor

openshift-bot commented Apr 13, 2021

/retest

Please review the full test history for this PR and help us cut down flakes.

Contributor

openshift-bot commented Apr 13, 2021

/retest

Please review the full test history for this PR and help us cut down flakes.

Contributor

openshift-bot commented Apr 13, 2021

/retest

Please review the full test history for this PR and help us cut down flakes.

Contributor

openshift-bot commented Apr 13, 2021

/retest

Please review the full test history for this PR and help us cut down flakes.

Contributor

openshift-bot commented Apr 13, 2021

/retest

Please review the full test history for this PR and help us cut down flakes.

Contributor

openshift-bot commented Apr 13, 2021

/retest

Please review the full test history for this PR and help us cut down flakes.

Contributor

openshift-bot commented Apr 13, 2021

/retest

Please review the full test history for this PR and help us cut down flakes.

Contributor

openshift-bot commented Apr 13, 2021

/retest

Please review the full test history for this PR and help us cut down flakes.

Contributor

openshift-bot commented Apr 13, 2021

/retest

Please review the full test history for this PR and help us cut down flakes.

Contributor

openshift-bot commented Apr 13, 2021

/retest

Please review the full test history for this PR and help us cut down flakes.

Contributor

openshift-bot commented Apr 14, 2021

/retest

Please review the full test history for this PR and help us cut down flakes.

26 similar comments

Contributor

openshift-bot commented Apr 14, 2021

/retest

Please review the full test history for this PR and help us cut down flakes.

Contributor

openshift-bot commented Apr 14, 2021

/retest

Please review the full test history for this PR and help us cut down flakes.

Contributor

openshift-bot commented Apr 14, 2021

/retest

Please review the full test history for this PR and help us cut down flakes.

Contributor

openshift-bot commented Apr 14, 2021

/retest

Please review the full test history for this PR and help us cut down flakes.

Contributor

openshift-bot commented Apr 14, 2021

/retest

Please review the full test history for this PR and help us cut down flakes.

Contributor

openshift-bot commented Apr 15, 2021

/retest

Please review the full test history for this PR and help us cut down flakes.

Contributor

openshift-bot commented Apr 15, 2021

/retest

Please review the full test history for this PR and help us cut down flakes.

Contributor

openshift-bot commented Apr 15, 2021

/retest

Please review the full test history for this PR and help us cut down flakes.

Contributor

openshift-bot commented Apr 15, 2021

/retest

Please review the full test history for this PR and help us cut down flakes.

Contributor

openshift-bot commented Apr 15, 2021

/retest

Please review the full test history for this PR and help us cut down flakes.

Contributor

openshift-bot commented Apr 15, 2021

/retest

Please review the full test history for this PR and help us cut down flakes.

Contributor

openshift-bot commented Apr 15, 2021

/retest

Please review the full test history for this PR and help us cut down flakes.

Contributor

openshift-bot commented Apr 15, 2021

/retest

Please review the full test history for this PR and help us cut down flakes.

Contributor

openshift-bot commented Apr 15, 2021

/retest

Please review the full test history for this PR and help us cut down flakes.

Contributor

openshift-bot commented Apr 15, 2021

/retest

Please review the full test history for this PR and help us cut down flakes.

Contributor

openshift-bot commented Apr 15, 2021

/retest

Please review the full test history for this PR and help us cut down flakes.

Contributor

openshift-bot commented Apr 15, 2021

/retest

Please review the full test history for this PR and help us cut down flakes.

Contributor

openshift-bot commented Apr 15, 2021

/retest

Please review the full test history for this PR and help us cut down flakes.

Contributor

openshift-bot commented Apr 15, 2021

/retest

Please review the full test history for this PR and help us cut down flakes.

Contributor

openshift-bot commented Apr 15, 2021

/retest

Please review the full test history for this PR and help us cut down flakes.

Contributor

openshift-bot commented Apr 15, 2021

/retest

Please review the full test history for this PR and help us cut down flakes.

Contributor

openshift-bot commented Apr 16, 2021

/retest

Please review the full test history for this PR and help us cut down flakes.

Contributor

openshift-bot commented Apr 16, 2021

/retest

Please review the full test history for this PR and help us cut down flakes.

Contributor

openshift-bot commented Apr 16, 2021

/retest

Please review the full test history for this PR and help us cut down flakes.

Contributor

openshift-bot commented Apr 16, 2021

/retest

Please review the full test history for this PR and help us cut down flakes.

Contributor

openshift-bot commented Apr 16, 2021

/retest

Please review the full test history for this PR and help us cut down flakes.

Contributor

openshift-ci bot commented Apr 16, 2021 •

edited

Loading

@bertinatto: The following tests failed, say /retest to rerun all failed tests:

Test name	Commit	Details	Rerun command
ci/prow/e2e-vsphere-csi	`0612ea4`	link	`/test e2e-vsphere-csi`
ci/prow/e2e-azure-csi	`0612ea4`	link	`/test e2e-azure-csi`

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

openshift-merge-robot merged commit c2970b1 into openshift:master

Contributor

openshift-ci-robot commented Apr 17, 2021

@bertinatto: All pull requests linked via external trackers have merged:

openshift/cluster-storage-operator#156

Bugzilla bug 1948505 has been moved to the MODIFIED state.

Details

In response to this:

Bug 1948505: Add missing RBAC rules for vSphere

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved bugzilla/severity-high bugzilla/valid-bug lgtm