Skip to content

Handle unsupported platform errors gracefully #14

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
openshift-merge-robot merged 2 commits into from
Feb 21, 2019
Merged

Handle unsupported platform errors gracefully #14

openshift-merge-robot merged 2 commits into from
Feb 21, 2019

Conversation

@gnufied
Copy link
Member

@gnufied gnufied commented Feb 20, 2019

Unsupported platform isn't really a fatal error. We are just not going to install a storageclass. This fixes deployment on libvirt.

@openshift-ci-robot openshift-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Feb 20, 2019
@smarterclayton
Copy link
Contributor

smarterclayton commented Feb 20, 2019

Yeah, as a general rule all operators everywhere must gracefully tolerate unrecognized platforms. See https://github.com/openshift/api/blob/master/config/v1/types_infrastructure.go#L34 for a quick description and
openshift/installer#1112 for more details

@jsafrane
Copy link
Contributor

jsafrane commented Feb 20, 2019

This code lgtm, however, should the operator tell user somehow that it's running correctly but did not do anything useful on an unknown platform? "I see the operator running, it does not report any error, so where is my default storage class?"

bertinatto
bertinatto reviewed Feb 20, 2019
View reviewed changes
@openshift-ci-robot openshift-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Feb 20, 2019
@gnufied
Copy link
Member Author

gnufied commented Feb 20, 2019

@jsafrane added reason field if unsupported platform is detected. PTAL

@wongma7
Copy link

wongma7 commented Feb 20, 2019

reason should be camelcase. maybe put it in Message instead?

@gnufied gnufied force-pushed the handle-unsupported-platform-errors branch from 7c16667 to d94365d Compare February 20, 2019 15:52
@gnufied
Copy link
Member Author

gnufied commented Feb 20, 2019

@wongma7 fixed.

@jsafrane
Copy link
Contributor

jsafrane commented Feb 20, 2019

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Feb 20, 2019
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Feb 20, 2019

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: gnufied, jsafrane

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@gnufied
Copy link
Member Author

gnufied commented Feb 20, 2019

/test e2e-aws
/test images

@openshift-bot
Copy link
Contributor

openshift-bot commented Feb 20, 2019

/retest

Please review the full test history for this PR and help us cut down flakes.

5 similar comments
@openshift-bot
Copy link
Contributor

openshift-bot commented Feb 20, 2019

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

openshift-bot commented Feb 20, 2019

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

openshift-bot commented Feb 20, 2019

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

openshift-bot commented Feb 21, 2019

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

openshift-bot commented Feb 21, 2019

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-merge-robot openshift-merge-robot merged commit dc42489 into openshift:master Feb 21, 2019
@wongma7 wongma7 mentioned this pull request Feb 26, 2019
Closed
@abhinavdahiya abhinavdahiya mentioned this pull request Mar 4, 2019
Closed
gnufied pushed a commit to gnufied/cluster-storage-operator that referenced this pull request Dec 4, 2019
@openshift-merge-robot
Merge pull request openshift#14 from sanchezl/storage-migration
12ec444 
storage-migration-for-etcd-encryption proposal
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@childsb childsb Awaiting requested review from childsb

1 more reviewer

@bertinatto bertinatto bertinatto left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@jsafrane jsafrane

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

8 participants

@gnufied @smarterclayton @jsafrane @wongma7 @openshift-ci-robot @openshift-bot @bertinatto @openshift-merge-robot