Skip to content

Conversation

@Prashanth684
Copy link
Contributor

With support landing for importing manifestlists in imagestreams (https://issues.redhat.com/browse/IR-192), making these import the manifestlist by default will help when clusters are installed with the manifestlisted multi release payload and compute nodes of different architectures are added. This will help the CI nightly test suites run without errors on a cluster with multi arch compute nodes and also enable commands like oc debug and must-gather to run on these nodes.

With support landing for importing manifestlists in imagestreams (https://issues.redhat.com/browse/IR-192), making these import the manifestlist by default
will help when clusters are installed with the manifestlisted multi release payload and compute nodes of different architectures are added. This will help
the CI nightly test suites run without errors on a cluster with multi arch compute nodes and also enable commands like oc debug and must-gather to
run on these nodes.
@Prashanth684
Copy link
Contributor Author

/retest

@fbm3307
Copy link
Contributor

fbm3307 commented Jan 23, 2023

/retest-required

@fbm3307
Copy link
Contributor

fbm3307 commented Jan 23, 2023

/test e2e-aws-proxy

1 similar comment
@Prashanth684
Copy link
Contributor Author

/test e2e-aws-proxy

@Prashanth684
Copy link
Contributor Author

@fbm3307 the e2e-aws-proxy test seems to be failing for an unrelated reason. otherwise all other tests have passed.

@fbm3307
Copy link
Contributor

fbm3307 commented Jan 25, 2023

@Prashanth684 let me check this

@fbm3307
Copy link
Contributor

fbm3307 commented Jan 25, 2023

/test e2e-aws-ovn-image-ecosystem

@Prashanth684
Copy link
Contributor Author

all required jobs are passing. @fbm3307 good for approval?

@fbm3307
Copy link
Contributor

fbm3307 commented Jan 27, 2023

@Prashanth684 PR is good for approval, but for approval it will require bugzilla valid bug referenced here.. Can you add that..?

@Prashanth684 Prashanth684 added px-approved Signifies that Product Support has signed off on this PR docs-approved Signifies that Docs has signed off on this PR labels Jan 27, 2023
@aleskandro
Copy link
Member

/label qe-approved

@openshift-ci openshift-ci bot added the qe-approved Signifies that QE has signed off on this PR label Jan 27, 2023
@Prashanth684
Copy link
Contributor Author

@fbm3307 added the px,docs and qe-approved label since this is not a bug. should be good for approval now.

@fbm3307
Copy link
Contributor

fbm3307 commented Jan 28, 2023

/lgtm
/approved

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jan 28, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jan 28, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: fbm3307, Prashanth684

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 28, 2023
@openshift-ci-robot
Copy link
Contributor

/retest-required

Remaining retests: 0 against base HEAD 0182981 and 2 for PR HEAD 2c3bace in total

@fbm3307
Copy link
Contributor

fbm3307 commented Jan 30, 2023

/retest

@aleskandro
Copy link
Member

/retest-required

1 similar comment
@Prashanth684
Copy link
Contributor Author

/retest-required

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jan 31, 2023

@Prashanth684: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/okd-e2e-aws-builds 2c3bace link false /test okd-e2e-aws-builds
ci/prow/okd-e2e-aws-image-ecosystem 2c3bace link false /test okd-e2e-aws-image-ecosystem
ci/prow/e2e-aws-proxy 2c3bace link false /test e2e-aws-proxy
ci/prow/okd-scos-e2e-aws-ovn 2c3bace link false /test okd-scos-e2e-aws-ovn
ci/prow/okd-e2e-aws-ovn-upgrade 2c3bace link false /test okd-e2e-aws-ovn-upgrade
ci/prow/okd-scos-e2e-aws-image-ecosystem 2c3bace link false /test okd-scos-e2e-aws-image-ecosystem
ci/prow/e2e-aws-ovn-proxy 2c3bace link false /test e2e-aws-ovn-proxy
ci/prow/okd-scos-e2e-aws-upgrade 2c3bace link false /test okd-scos-e2e-aws-upgrade
ci/prow/okd-e2e-aws-ovn-image-ecosystem 2c3bace link false /test okd-e2e-aws-ovn-image-ecosystem
ci/prow/okd-e2e-aws-ovn 2c3bace link false /test okd-e2e-aws-ovn

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-merge-robot openshift-merge-robot merged commit 69a9315 into openshift:master Jan 31, 2023
Prashanth684 added a commit to Prashanth684/driver-toolkit that referenced this pull request Mar 19, 2024
manifestlisted image

Similar to
openshift/cluster-samples-operator#482, we want
CVO managed imagestreams to have the importMode as preserveOriginal so
that it imports the manifestlisted image with all arches so that it
works on a multi-arch compute cluster
openshift-merge-bot bot pushed a commit to openshift/driver-toolkit that referenced this pull request Apr 3, 2024
manifestlisted image

Similar to
openshift/cluster-samples-operator#482, we want
CVO managed imagestreams to have the importMode as preserveOriginal so
that it imports the manifestlisted image with all arches so that it
works on a multi-arch compute cluster
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. docs-approved Signifies that Docs has signed off on this PR lgtm Indicates that a PR is ready to be merged. px-approved Signifies that Product Support has signed off on this PR qe-approved Signifies that QE has signed off on this PR

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants