-
Notifications
You must be signed in to change notification settings - Fork 95
Change importMode to preserveOriginal for Openshift imagestreams #482
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change importMode to preserveOriginal for Openshift imagestreams #482
Conversation
With support landing for importing manifestlists in imagestreams (https://issues.redhat.com/browse/IR-192), making these import the manifestlist by default will help when clusters are installed with the manifestlisted multi release payload and compute nodes of different architectures are added. This will help the CI nightly test suites run without errors on a cluster with multi arch compute nodes and also enable commands like oc debug and must-gather to run on these nodes.
|
/retest |
|
/retest-required |
|
/test e2e-aws-proxy |
1 similar comment
|
/test e2e-aws-proxy |
|
@fbm3307 the e2e-aws-proxy test seems to be failing for an unrelated reason. otherwise all other tests have passed. |
|
@Prashanth684 let me check this |
|
/test e2e-aws-ovn-image-ecosystem |
|
all required jobs are passing. @fbm3307 good for approval? |
|
@Prashanth684 PR is good for approval, but for approval it will require bugzilla valid bug referenced here.. Can you add that..? |
|
/label qe-approved |
|
@fbm3307 added the px,docs and qe-approved label since this is not a bug. should be good for approval now. |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: fbm3307, Prashanth684 The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/retest |
|
/retest-required |
1 similar comment
|
/retest-required |
|
@Prashanth684: The following tests failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
manifestlisted image Similar to openshift/cluster-samples-operator#482, we want CVO managed imagestreams to have the importMode as preserveOriginal so that it imports the manifestlisted image with all arches so that it works on a multi-arch compute cluster
manifestlisted image Similar to openshift/cluster-samples-operator#482, we want CVO managed imagestreams to have the importMode as preserveOriginal so that it imports the manifestlisted image with all arches so that it works on a multi-arch compute cluster
With support landing for importing manifestlists in imagestreams (https://issues.redhat.com/browse/IR-192), making these import the manifestlist by default will help when clusters are installed with the manifestlisted multi release payload and compute nodes of different architectures are added. This will help the CI nightly test suites run without errors on a cluster with multi arch compute nodes and also enable commands like oc debug and must-gather to run on these nodes.