Cfg cluster op group

[gabemontero]

per recent aos-devel announce from clayton ... moving to config.openshift.io

/assign @bparees

@openshift/sig-developer-experience fyi / ptal

[openshift-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: gabemontero

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• OWNERS [gabemontero]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[gabemontero]

another test of the new e2e job @bparees :-)

[gabemontero]

oops forgot the unit test

[bparees]

@gabemontero since we have that awesome new e2e job, please add a test that confirms the clusteroperator object is getting created w/ appropriate status information.

[gabemontero]

assuming I get a clean run as-is @bparees, sure

[gabemontero]

aws nat pain on e2e-aws:

aws_eip.nat_eip.2: Error creating EIP: AddressLimitExceeded: The maximum number of addresses has been reached.
	status code: 400, request id: b28de6e6-5933-478b-a950-dad7d8006a2f
* module.vpc.aws_eip.nat_eip[3]: 1 error(s) occurred:

[gabemontero]

same nat pain with our new e2e job ... posted on forum-testplatform

[gabemontero]

/retest

[gabemontero]

the new e2e test failed on a timeout ... it never found the ruby imagestream

i have the new test ... hopefully I can debug what is up with the existing test while I vet out the new one

[gabemontero]

ah ha:

time="2018-11-07T19:05:44Z" level=error msg="error updating cluster operator status: failed to get cluster operator resource openshift-cluster-samples-operator/openshift-samples: clusterversions.config.openshift.io \"openshift-samples\" is forbidden: User \"system:serviceaccount:openshift-cluster-samples-operator:cluster-samples-operator\" cannot get clusterversions.config.openshift.io at the cluster scope: no RBAC policy matched"

more changes needed ....

[gabemontero]

A bit stuck ...my email to aos-devel:

Ok, after

• updating my operator's clusterrole rbac's to deal with ClusterVersion

• adding k8sutil.AddToSDKScheme(ocfgapi.AddToScheme) to register the new type with the operator sdk (where ocfgapi is "github.com/openshift/cluster-version-operator/pkg/apis/config.openshift.io/v1") after getting unknown type messages from the operator sdk

I can't seem to get past this error when I attempt to get/update/create my ClusterVersion

"error updating cluster operator status: failed to unmarshal the retrieved data: failed to decode json data with gvk(config.openshift.io/v1, Kind=ClusterVersion): v1.ClusterVersion.Spec: v1.ClusterVersionSpec.Upstream: DesiredUpdate: ClusterID: unmarshalerDecoder: invalid UUID length: 0, error found in #10 byte of ...|sterID\":\"\",\"desiredU|..., bigger context ...|723e82c3772e\"},\"spec\":{\"channel\":\"\",\"clusterID\":\"\",\"desiredUpdate\":null,\"upstream\":null}}\n|..."

The comment for the DesiredUpdate field notes it is optional.

Any insights on how to make the operator sdk work with ClusterVersion? Or should I be using a different client?

I do get the following ClusterVersion (with the status missing as a result of the error I previously noted)

apiVersion: config.openshift.io/v1
kind: ClusterVersion
metadata:
  creationTimestamp: 2018-11-07T19:40:06Z
  generation: 1
  name: openshift-samples
  resourceVersion: "218197"
  selfLink: /apis/config.openshift.io/v1/clusterversions/openshift-samples
  uid: edb58aeb-e2c4-11e8-b436-723e82c3772e
spec:
  channel: ""
  clusterID: ""
  desiredUpdate: null
  upstream: null

[bparees]

@gabemontero have you bumped openshift/api and openshift/client-go in this repo?

[bparees]

(actually that may not matter)

[openshift-ci-robot]

@gabemontero: The following test failed, say /retest to rerun them all:

Test name	Commit	Details	Rerun command
ci/prow/e2e-aws-operator	489e0fc	link	/test e2e-aws-operator

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

[bparees]

clusterversions.config.openshift.io ?

[bparees]

(honestly i dunno that we need to keep this file around anymore, it was a useful development tool when we stood up clusters manually but now that the installer is the only way, we can rely on the installer to have created this CRD in all our clusters)

[gabemontero]

yeah I just as soon delete it ... will do that when I circle back to this PR (pending response to my outstanding client question I've circled back to implementing the progressing condition for image streams)

[bparees]

i don't think this was supposed to change. the resource type is still clusteroperators.

[gabemontero]

total mix up on my part ... @bparees got me back on track ... waiting on @dmage 's openshift/cluster-version-operator#48