Bug 1825774: add back missing parts to make openshift-config namespace secret list… #264
Conversation
|
@gabemontero: This pull request references Bugzilla bug 1825774, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker. 3 validation(s) were run on this bug
DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
@gabemontero: This pull request references Bugzilla bug 1825774, which is valid. The bug has been moved to the POST state. 3 validation(s) were run on this bug
DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
openshift-ci-robot
added
the
bugzilla/valid-bug
|
was able to verify on a local cluster ... able to retrieve the secret now |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: gabemontero The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
1 similar comment
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: gabemontero The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci-robot
added
approved
ricardomaraschini
left a comment
ricardomaraschini
left a comment
There was a problem hiding this comment.
It looks good to me but I admit I don't understand exactly why we need to react to changes on these secrets. Would you mind explain a little bit in here?
Yep I'll add some comments in the code. I gave a very terse summary in this PR's description, but perhaps too terse. For posterity, I'll clarify here as well:
|
|
ok @ricardomaraschini I've added the comment explaining stuff ... let me know if you think that is sufficient, and if it is, I'll squash, etc. thanks |
Yep, thanks for that extra explanation. Squash them and I will LGTM. |
gabemontero
force-pushed
the
fix-pull-secret-check
branch
from
7462324 to
13ea45a
Compare
|
commits squashed @ricardomaraschini - thanks |
|
/test unit |
1 similar comment
|
/test unit |
|
unit test flake gone |
|
@gabemontero: All pull requests linked via external trackers have merged: openshift/cluster-samples-operator#264. Bugzilla bug 1825774 has been moved to the MODIFIED state. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
1 similar comment
|
@gabemontero: All pull requests linked via external trackers have merged: openshift/cluster-samples-operator#264. Bugzilla bug 1825774 has been moved to the MODIFIED state. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
5 participants
…er functional
got a little too aggressive in removing operator related bits for the openshift-config secret lister
still need to create a workqueue and informer to enable it to obtain the secret
even though we no longer copy the secret, still inspect it to make sure it has creds for registry.redhat.io
/assign @ricardomaraschini
/assign @dmage
if one of you all have cycles please review - thanks