Skip to content

Add baremetal-installer to image-references #170

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
openshift-merge-robot merged 1 commit into from
Aug 14, 2019
Merged

Add baremetal-installer to image-references #170

openshift-merge-robot merged 1 commit into from
Aug 14, 2019

Conversation

@stbenjam
Copy link
Member

@stbenjam stbenjam commented Aug 13, 2019

This adds the baremetal-installer to image-references so it is included
in releases.

@stbenjam
Add baremetal-installer to image-references
f070c14 
This adds the baremetal-installer to image-references so it is included
in releases.
@openshift-ci-robot openshift-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Aug 13, 2019
@stbenjam stbenjam mentioned this pull request Aug 13, 2019
Closed
@gabemontero
Copy link
Contributor

gabemontero commented Aug 13, 2019

/approve

@gabemontero
Copy link
Contributor

gabemontero commented Aug 13, 2019

/lgtm

@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Aug 13, 2019

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: gabemontero, stbenjam

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added lgtm Indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Aug 13, 2019
@stbenjam
Copy link
Member Author

stbenjam commented Aug 13, 2019 •
edited
Loading

openshift/release#4729 was just merged, we'll need to wait some time for the images to become available.

@openshift-bot
Copy link
Contributor

openshift-bot commented Aug 13, 2019

/retest

Please review the full test history for this PR and help us cut down flakes.

7 similar comments
@openshift-bot
Copy link
Contributor

openshift-bot commented Aug 13, 2019

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

openshift-bot commented Aug 13, 2019

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

openshift-bot commented Aug 13, 2019

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

openshift-bot commented Aug 13, 2019

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

openshift-bot commented Aug 13, 2019

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

openshift-bot commented Aug 13, 2019

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

openshift-bot commented Aug 13, 2019

/retest

Please review the full test history for this PR and help us cut down flakes.

@gabemontero
Copy link
Contributor

gabemontero commented Aug 13, 2019

yep it is not available yet: https://prow.svc.ci.openshift.org/view/gcs/origin-ci-test/pr-logs/pull/openshift_cluster-samples-operator/170/pull-ci-openshift-cluster-samples-operator-master-images/428#0:build-log.txt%3A54

/hold

@openshift-ci-robot openshift-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 13, 2019
@stbenjam stbenjam mentioned this pull request Aug 14, 2019
Merged
@stbenjam
Copy link
Member Author

stbenjam commented Aug 14, 2019 •
edited
Loading

They should be available on registry.svc.ci.openshift.org now

/hold cancel

@openshift-ci-robot openshift-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 14, 2019
@stbenjam
Copy link
Member Author

stbenjam commented Aug 14, 2019

/retest

1 similar comment
@eparis
Copy link
Member

eparis commented Aug 14, 2019

/retest

@openshift-merge-robot openshift-merge-robot merged commit c895562 into openshift:master Aug 14, 2019
@stbenjam stbenjam deleted the baremetal-installer branch August 14, 2019 14:01
wking added a commit to wking/cluster-samples-operator that referenced this pull request Aug 14, 2019
@wking
Revert "Add baremetal-installer to image-references"
3484c0f 
This reverts commit f070c14, openshift#170

It's failing for ART-built nightlies [1]:

  error: unable to create a release: operator "cluster-samples-operator" contained an invalid image-references file: no input image tag named "baremetal-installer"

[1]: https://openshift-release.svc.ci.openshift.org/releasestream/4.2.0-0.nightly/release/4.2.0-0.nightly-2019-08-14-154809
@wking wking mentioned this pull request Aug 14, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@adambkaplan adambkaplan Awaiting requested review from adambkaplan

@coreydaley coreydaley Awaiting requested review from coreydaley

Assignees

@gabemontero gabemontero

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@stbenjam @gabemontero @openshift-ci-robot @openshift-bot @eparis @openshift-merge-robot