Get secret/configmaps information from config for all IdPs #24

stlaz · 2019-01-16T11:59:32Z

Grabs identity providers' configmaps and secrets from the
top-level config and stores their mapping to volumes/volumeMounts
so that these can later be added to the deployment running OSIN

stlaz · 2019-01-16T12:22:44Z

Note to self: get rid of idpSyncData, it does not seem to be bringing any value, only overhead

edit: or at least only fill it once, don't create an array of those

ericavonb

A few small comments. There’s more consolidation that could be done but this is a good step forward without that

pkg/operator2/configsync.go

ericavonb · 2019-01-16T12:39:45Z

pkg/operator2/configsync.go

+
 		default:
-			panic("TODO")
+			return nil // TODO: some erroring


return fmt.Errorf(“unknown IdentityProvider type: %s”, pc.Type)

And thank you, no panics!

The function currently only returns []idpSyncData, I'd maybe fix this when gets merged with convertProviderConfigToOsinBytes()

icky, ok. for another pr

pkg/operator2/configsync.go

stlaz · 2019-01-16T13:57:47Z

Fixed comments, rebased on master.

I also added a refactoring to convertToData() which now only returns a pointer to the idpSyncData structure. Lets' hope nothing breaks!

ericavonb

one typo to fix

ericavonb · 2019-01-16T14:00:10Z

pkg/operator2/configsync.go

+
 		default:
-			panic("TODO")
+			return nil // TODO: some erroring


icky, ok. for another pr

pkg/operator2/configsync.go

stlaz · 2019-01-16T14:10:15Z

typo fixed

stlaz · 2019-01-16T14:38:43Z

latest push fixes writing to nil maps

stlaz · 2019-01-16T15:01:33Z

I chipped away the refactoring so that we can merge this earlier. See #26 for the follow-up.

Grabs identity providers' configmaps and secrets from the top-level config and stores their mapping to volumes/volumeMounts so that these can later be added to the deployment running OSIN

stlaz · 2019-01-16T15:06:03Z

Fixed bug in newSourceDataIDPConfigMap(), it had secretVolume() instead of the proper volume func.

stlaz · 2019-01-16T16:01:19Z

/test e2e-aws

enj · 2019-01-16T16:55:57Z

/retest

ericavonb

/lgtm

openshift-ci-robot · 2019-01-16T17:18:51Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ericavonb, stlaz

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

~~OWNERS~~ [ericavonb,stlaz]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

stlaz · 2019-01-16T17:31:20Z

/retest

enj · 2019-01-16T17:46:13Z

Tested with 4.0 cluster, htpasswd still works so this is hopefully fine.

/retest

openshift-bot · 2019-01-16T17:53:53Z

/retest

Please review the full test history for this PR and help us cut down flakes.

stlaz · 2019-01-16T19:19:29Z

/retest

stlaz · 2019-01-16T19:49:03Z

/retest

openshift-bot · 2019-01-16T21:55:45Z

/retest

Please review the full test history for this PR and help us cut down flakes.

enj · 2019-01-16T22:24:56Z

/retest

enj · 2019-01-16T23:13:04Z

/retest

enj · 2019-01-16T23:46:46Z

/retest

enj · 2019-01-17T00:53:58Z

/retest

enj · 2019-01-17T01:52:30Z

/retest

openshift-bot · 2019-01-17T06:00:07Z

/retest

Please review the full test history for this PR and help us cut down flakes.

stlaz · 2019-01-17T07:46:04Z

/retest

enj · 2019-01-17T11:37:00Z

/refresh

openshift-ci-robot · 2019-01-17T11:55:51Z

@stlaz: The following test failed, say /retest to rerun them all:

Test name	Commit	Details	Rerun command
ci/prow/e2e-aws-operator	`9330345`	link	`/test e2e-aws-operator`

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

openshift-bot · 2019-01-17T12:04:18Z

/retest

Please review the full test history for this PR and help us cut down flakes.

stlaz · 2019-01-17T13:15:01Z

/test e2e-aws-operator

enj · 2019-01-17T13:38:39Z

/retest

stlaz · 2019-01-17T13:53:14Z

/retest

openshift-bot · 2019-01-17T14:03:32Z

/retest

Please review the full test history for this PR and help us cut down flakes.

enj · 2019-01-17T14:38:14Z

kube:admin still works. Time for the 🔨

openshift-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Jan 16, 2019

openshift-ci-robot requested review from enj and ericavonb January 16, 2019 11:59

ericavonb suggested changes Jan 16, 2019

View reviewed changes

stlaz force-pushed the idp_mapping branch from d805011 to 6cabad5 Compare January 16, 2019 13:54

openshift-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jan 16, 2019

stlaz force-pushed the idp_mapping branch from 6cabad5 to 37a113c Compare January 16, 2019 13:56

openshift-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jan 16, 2019

ericavonb suggested changes Jan 16, 2019

View reviewed changes

stlaz force-pushed the idp_mapping branch from 37a113c to 5d059c6 Compare January 16, 2019 14:09

stlaz force-pushed the idp_mapping branch 2 times, most recently from d3d794c to d50ca16 Compare January 16, 2019 14:58

stlaz force-pushed the idp_mapping branch from d50ca16 to 9330345 Compare January 16, 2019 15:04

Get secret/configmaps information from config for all IdPs

9330345

Grabs identity providers' configmaps and secrets from the top-level config and stores their mapping to volumes/volumeMounts so that these can later be added to the deployment running OSIN

openshift-ci-robot assigned ericavonb Jan 16, 2019

ericavonb approved these changes Jan 16, 2019

View reviewed changes

openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Jan 16, 2019

stlaz mentioned this pull request Jan 17, 2019

Merge top-level IdP config traversal functions, check for improper IdP config #28

Closed

enj merged commit a61a78d into openshift:master Jan 17, 2019

stlaz deleted the idp_mapping branch February 18, 2019 07:47

Get secret/configmaps information from config for all IdPs #24

Get secret/configmaps information from config for all IdPs #24

Uh oh!

Conversation

stlaz commented Jan 16, 2019

Uh oh!

stlaz commented Jan 16, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

ericavonb left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

ericavonb Jan 16, 2019

Choose a reason for hiding this comment

Uh oh!

ericavonb Jan 16, 2019

Choose a reason for hiding this comment

Uh oh!

stlaz Jan 16, 2019

Choose a reason for hiding this comment

Uh oh!

ericavonb Jan 16, 2019

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

stlaz commented Jan 16, 2019

Uh oh!

ericavonb left a comment

Choose a reason for hiding this comment

Uh oh!

ericavonb Jan 16, 2019

Choose a reason for hiding this comment

Uh oh!

Uh oh!

stlaz commented Jan 16, 2019

Uh oh!

stlaz commented Jan 16, 2019

Uh oh!

stlaz commented Jan 16, 2019

Uh oh!

stlaz commented Jan 16, 2019

Uh oh!

stlaz commented Jan 16, 2019

Uh oh!

enj commented Jan 16, 2019

Uh oh!

ericavonb left a comment

Choose a reason for hiding this comment

Uh oh!

openshift-ci-robot commented Jan 16, 2019

Uh oh!

stlaz commented Jan 16, 2019

Uh oh!

enj commented Jan 16, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

openshift-bot commented Jan 16, 2019

Uh oh!

stlaz commented Jan 16, 2019

Uh oh!

stlaz commented Jan 16, 2019

Uh oh!

openshift-bot commented Jan 16, 2019

Uh oh!

enj commented Jan 16, 2019

Uh oh!

enj commented Jan 16, 2019

Uh oh!

enj commented Jan 16, 2019

Uh oh!

enj commented Jan 17, 2019

Uh oh!

enj commented Jan 17, 2019

Uh oh!

openshift-bot commented Jan 17, 2019

Uh oh!

stlaz commented Jan 17, 2019

stlaz commented Jan 16, 2019 •

edited

Loading

enj commented Jan 16, 2019 •

edited

Loading