report status to the CVO #20
Conversation
openshift-ci-robot
added
the
do-not-merge/work-in-progress
openshift-ci-robot
added
the
do-not-merge/hold
openshift-ci-robot
added
the
size/L
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: deads2k The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci-robot
added
the
approved
| // sync reacts to a change in prereqs by finding information that is required to match another value in the cluster. This | ||
| // must be information that is logically "owned" by another component. | ||
| func (c StatusSyncer) sync() error { | ||
| currentDetailedStatus, err := c.operatorStatusProvider.CurrentStatus() |
There was a problem hiding this comment.
can't we just set the ownerRef and let GC to deal with this?
There was a problem hiding this comment.
can't we just set the ownerRef and let GC to deal with this?
GC doesn't do cluster scoped resources.
| return operatorv1alpha1.OperatorStatus{}, err | ||
| } | ||
|
|
||
| return instance.Status.OperatorStatus, nil |
| defer utilruntime.HandleCrash() | ||
| defer c.queue.ShutDown() | ||
|
|
||
| glog.Infof("Starting ConfigObserver") |
|
@tnozicka any idea what is up with Travis and tide? |
| return err | ||
| } | ||
|
|
||
| operatorConfig, err := c.clusterOperatorClient.Get(c.clusterOperatorName, metav1.GetOptions{}) |
There was a problem hiding this comment.
odd the get the same object again.
There was a problem hiding this comment.
odd the get the same object again.
Uncommon, but dynamic informers/listers are in 1.13 and this is fairly slow moving.
| return createErr | ||
| } | ||
| } | ||
| if updateErr != nil { |
| return nil, nil | ||
| } | ||
| buf := &bytes.Buffer{} | ||
| if err := json.NewEncoder(buf).Encode(condition); err != nil { |
There was a problem hiding this comment.
ugly. I guess we don't have go types yet of this object?
There was a problem hiding this comment.
ugly. I guess we don't have go types yet of this object?
For the CVO ClusterOperator status? Not yet.
|
some nits |
openshift-ci-robot
removed
the
do-not-merge/work-in-progress
|
/hold cancel |
openshift-ci-robot
removed
the
do-not-merge/hold
6 participants
Uses openshift/cluster-version-operator#31, a dynamic client, and the operator status used by several operator to create a control loop that will keep the
ClusterOperatorsynchronized if the API is available./cc @abhinavdahiya
/assign @mfojtik @sttts @sanchezl
/hold
hold until we roughly agree on the upstream shape. This will require us to re-fit some conditions.