add exclusion annotations to all resources#136
add exclusion annotations to all resources#136KodieGlosserIBM wants to merge 3 commits intoopenshift:masterfrom
Conversation
openshift-ci-robot
added
the
size/S
|
heh, i thought this went in at same time as openshift/cluster-openshift-apiserver-operator#258 , guess not... |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: bparees, KodieGlosserIBM The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci-robot
added
the
approved
|
/retest Please review the full test history for this PR and help us cut down flakes. |
1 similar comment
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
@bparees @derekwaynecarr I assume this needs a backport to |
… to stay consistent with 4.2 CVO. As seen here, the 4.3 CVO looks at the value when looking at exclusions
…-controller-manager-operator
|
New changes are detected. LGTM label has been removed. |
|
@KodieGlosserIBM: The following tests failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
closing for now |
6 participants
- What I did
Added exclusion annotation so the 4.3 CVO will ignore these operators to stay consistent with 4.2 CVO. As seen here, the 4.3 CVO looks at the value when looking at exclusions https://github.com/openshift/hypershift-toolkit/blob/release-4.3/assets/cluster-version-operator/cluster-version-operator-deployment.yaml#L76-L77
The 4.2 CVO excluded the following operators and resources with those operators https://github.com/openshift/hypershift-toolkit/blob/release-4.2/assets/cluster-version-operator/cluster-version-operator-deployment.yaml#L60-L72
- How to verify it
Deploy the hypershift toolkit https://github.com/openshift/hypershift-toolkit/tree/release-4.2 and verify that all the resources with this exclusion (exclude.release.openshift.io/internal-openshift-hosted: "true") are not overwriting the ones being deployed into the cluster.
- Description for the changelog
added exclusion to the rest of the resources that the operator manages.