Skip to content

Conversation

@deads2k
Copy link
Contributor

@deads2k deads2k commented Dec 12, 2018

Reverts #91

/hold

lets see what CI says now.

@openshift-ci-robot openshift-ci-robot added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Dec 12, 2018
@openshift-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: deads2k

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 12, 2018
@vrutkovs
Copy link

This would flake a lot due to #86

@deads2k
Copy link
Contributor Author

deads2k commented Dec 13, 2018

This would flake a lot due to #86

Just looking for logs (which still appear to be missing). I think I found it in #93

@deads2k
Copy link
Contributor Author

deads2k commented Dec 17, 2018

/test all

@deads2k
Copy link
Contributor Author

deads2k commented Dec 17, 2018

green!

/test all

@deads2k
Copy link
Contributor Author

deads2k commented Dec 17, 2018

not green, but no clusteroperators at all....

/test e2e-aws

@deads2k
Copy link
Contributor Author

deads2k commented Dec 17, 2018

green

/test e2e-aws

@mfojtik
Copy link
Contributor

mfojtik commented Dec 17, 2018

LGTM (although the openshift-cluster-openshift-apiserver-operator looks weird ;-)

@deads2k
Copy link
Contributor Author

deads2k commented Dec 17, 2018

/test e2e-aws

5 similar comments
@deads2k
Copy link
Contributor Author

deads2k commented Dec 17, 2018

/test e2e-aws

@deads2k
Copy link
Contributor Author

deads2k commented Dec 20, 2018

/test e2e-aws

@deads2k
Copy link
Contributor Author

deads2k commented Jan 2, 2019

/test e2e-aws

@deads2k
Copy link
Contributor Author

deads2k commented Jan 2, 2019

/test e2e-aws

@deads2k
Copy link
Contributor Author

deads2k commented Jan 2, 2019

/test e2e-aws

@deads2k deads2k closed this Jan 3, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants