Bug 2101880: operator NS manifest: Set empty openshift.io/run-level #497
Conversation
We dropped the run-level label from this namespace back in 4.5 but because of how the cluster-version operator reconciles manifest labels, dropping a label from the manifest does not remove it from the in-cluster resource when old clusters are updated into the new manifest. This commit uses the approach the cluster-version operator used to drop its run-level, by setting the value to an empty string, which the run-level-consuming code treats identically to an unset label. This avoids errors about: ...container has runAsNonRoot and image will run as root... when updating to 4.11 in case the operator deployment manifest specifically requests runAsNonRoot: true.
openshift-ci
bot
added
bugzilla/severity-high
|
@stlaz: This pull request references Bugzilla bug 2101880, which is invalid:
Comment DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
stlaz
changed the title
|
/bugzilla refresh |
|
@stlaz: This pull request references Bugzilla bug 2102633, which is invalid:
Comment DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
@stlaz: This pull request references Bugzilla bug 2102633, which is invalid:
Comment DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
stlaz
changed the title
|
/bugzilla refresh |
openshift-ci
bot
added
bugzilla/valid-bug
|
@stlaz: This pull request references Bugzilla bug 2101880, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker. 3 validation(s) were run on this bug
Requesting review from QA contact: DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
@stlaz: all tests passed! Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
/lgtm |
|
/lgtm Thanks @stlaz |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ibihim, stlaz, tkashem The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
|
@stlaz: Some pull requests linked via external trackers have merged: The following pull requests linked via external trackers have not merged: These pull request must merge or be unlinked from the Bugzilla bug in order for it to move to the next state. Once unlinked, request a bug refresh with Bugzilla bug 2101880 has not been moved to the MODIFIED state. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/cherry-pick release-4.11 |
|
@sdodson: new pull request created: #499 DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
5 participants
We dropped the run-level label from this namespace back in 4.5
but because of how the cluster-version operator reconciles manifest
labels, dropping a label from the manifest does not remove it from the
in-cluster resource when old clusters are updated into the new
manifest. This commit uses the approach the cluster-version
operator used to drop its run-level, by setting the value to an
empty string, which the run-level-consuming code treats identically to
an unset label.
This avoids errors about:
...container has runAsNonRoot and image will run as root...
when updating to 4.11 in case the operator deployment manifest specifically
requests runAsNonRoot: true.