OCPBUGS-23167: Add performance real time tuned template #954
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,8 @@ | ||
| [main] | ||
| summary=Real time profile to override unsupported settings | ||
|
|
||
| [sysctl] | ||
| #Real time kernel doesn't support the following kernel parameters. | ||
| #The openshift-node-performance profile inherits these kernel parameters from the network-latency profile. | ||
| #Therefore, if the real time kernel is detected they will be dropped, meaning won't be applied. | ||
| drop=kernel.numa_balancing,net.core.busy_read,net.core.busy_poll |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -114,6 +114,21 @@ var _ = Describe("[rfe_id:27368][performance]", Ordered, func() { | |
| Expect(strings.TrimSpace(activeProfileName)).To(Equal(tunedExpectedName), "active profile name mismatch got %q expected %q", activeProfileName, tunedExpectedName) | ||
| } | ||
| }) | ||
|
|
||
| It("Tuned profile shouldn't be degraded", func() { | ||
|
Contributor
There was a problem hiding this comment. should not be degraded after what? in this test you check a condition (this part LGTM) but there is no obvious link to how to get to this state. IOW, does this test depend on a specific order? which part of the system creates the conditions we're checking?
Contributor
Author
There was a problem hiding this comment. should not be degraded after tuned profile has been applied to the system.
Contributor
There was a problem hiding this comment. @ffromani Any error in the tuned log causes the state to switch to degraded. This fix removes a typical case - a sysctl that does not exist for the given kernel.
Contributor
There was a problem hiding this comment. sure, and what in the test causes any change in the system which could lead to Degraded state? |
||
| for _, node := range workerRTNodes { | ||
| key := types.NamespacedName{ | ||
| Name: node.Name, | ||
| Namespace: components.NamespaceNodeTuningOperator, | ||
| } | ||
| tunedProfile := &tunedv1.Profile{} | ||
| err := testclient.Client.Get(context.TODO(), key, tunedProfile) | ||
| Expect(err).ToNot(HaveOccurred(), "Failed to get the Tuned profile for node %s", node.Name) | ||
| degradedCondition := findCondition(tunedProfile.Status.Conditions, "Degraded") | ||
| Expect(degradedCondition).ToNot(BeNil(), "Degraded condition not found in Tuned profile status") | ||
| Expect(degradedCondition.Status).To(Equal(corev1.ConditionFalse), "Tuned profile is degraded") | ||
| } | ||
| }) | ||
| }) | ||
|
|
||
| Context("Pre boot tuning adjusted by tuned ", func() { | ||
|
|
@@ -1345,3 +1360,13 @@ func makeDevRPSMap(content string) map[string]string { | |
| } | ||
| return devRPSMap | ||
| } | ||
|
|
||
| // Helper function to find a condition in the status.conditions slice by type | ||
| func findCondition(conditions []tunedv1.ProfileStatusCondition, conditionType string) *tunedv1.ProfileStatusCondition { | ||
| for _, condition := range conditions { | ||
| if string(condition.Type) == conditionType { | ||
| return &condition | ||
| } | ||
| } | ||
| return nil | ||
| } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
don't we want owner reference in this case? it should be only
no-refwithout the reference (hence the name)There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This syncs the manifests for this test https://github.com/openshift/cluster-node-tuning-operator/blob/master/test/e2e/performanceprofile/functests-render-command/1_render_command/render_test.go#L115
And it uses no owner references. Probably copy&paste. I believe we should default to having the references most of the time, but I do not think we should fix that as part of this PR.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fair enough