Skip to content

Remove pao namespace from watched namespaces#331

Closed
yanirq wants to merge 1 commit intoopenshift:masterfrom
yanirq:olm_fix
Closed

Remove pao namespace from watched namespaces#331
yanirq wants to merge 1 commit intoopenshift:masterfrom
yanirq:olm_fix

Conversation

@yanirq
Copy link
Contributor

@yanirq yanirq commented Mar 29, 2022

Performance addons operator namespace removed from the controller runtime manager's namespace watch list to decrease the number of watches.

The only code aligned to this fix is the PAO OLM removal which is a one time operation that will not use the namespace above explicitly.

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Mar 29, 2022

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: yanirq
To complete the pull request process, please assign jmencak after the PR has been reviewed.
You can assign the PR to them by writing /assign @jmencak in a comment when ready.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@yanirq
Copy link
Contributor Author

yanirq commented Mar 29, 2022

@jmencak
Copy link
Contributor

jmencak commented Mar 29, 2022

For reference, this should mitigate the issues mentioned here.

@jmencak
Copy link
Contributor

jmencak commented Mar 29, 2022

Quota exceeded
/retest

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Mar 29, 2022

@yanirq: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-aws-operator bdcd714 link true /test e2e-aws-operator
ci/prow/e2e-aws bdcd714 link true /test e2e-aws
ci/prow/e2e-gcp-pao bdcd714 link true /test e2e-gcp-pao
ci/prow/e2e-upgrade bdcd714 link true /test e2e-upgrade

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-ci openshift-ci bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Mar 29, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Mar 29, 2022

@yanirq: PR needs rebase.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@jmencak
Copy link
Contributor

jmencak commented Mar 29, 2022

I believe this PR can be closed, it is part of #332 now.

@yanirq
Copy link
Contributor Author

yanirq commented Apr 4, 2022

close as this is now part of #332

@yanirq yanirq closed this Apr 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

Comments