Skip to content

hack: fix installing the ginkgo #328

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
cynepco3hahue wants to merge 1 commit into from
Closed

hack: fix installing the ginkgo #328

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions hack/run-functests.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,8 +6,9 @@ LATENCY_TEST_RUN=${LATENCY_TEST_RUN:-"false"}
which ginkgo
if [ $? -ne 0 ]; then
echo "Downloading ginkgo tool"
#go install github.com/onsi/ginkgo/ginkgo
go install github.com/onsi/ginkgo/ginkgo@v1.16.5
# drop -mod=vendor flags, otherwise the installation will fail
# because of the package can not be installed under the vendor directory
GOFLAGS='' go install github.com/onsi/ginkgo/ginkgo@v1.16.5
fi

NO_COLOR=""
Expand Down
7 changes: 4 additions & 3 deletions hack/run-perf-profile-creator-functests.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,9 +4,10 @@ GINKGO_SUITS=${GINKGO_SUITS:-"test/e2e/pao/functests-performance-profile-creator

which ginkgo
if [ $? -ne 0 ]; then
echo "Downloading ginkgo tool"
#go install github.com/onsi/ginkgo/ginkgo
go install github.com/onsi/ginkgo/ginkgo@v1.16.5
echo "Downloading ginkgo tool"
# drop -mod=vendor flags, otherwise the installation will fail
# because of the package can not be installed under the vendor directory
GOFLAGS='' go install github.com/onsi/ginkgo/ginkgo@v1.16.5
fi

NO_COLOR=""
Expand Down
7 changes: 4 additions & 3 deletions hack/run-render-command-functests.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,9 +4,10 @@ GINKGO_SUITS=${GINKGO_SUITS:-"test/e2e/pao/functests-render-command"}

which ginkgo
if [ $? -ne 0 ]; then
echo "Downloading ginkgo tool"
#go install github.com/onsi/ginkgo/ginkgo
go install github.com/onsi/ginkgo/ginkgo@v1.16.5
echo "Downloading ginkgo tool"
# drop -mod=vendor flags, otherwise the installation will fail
# because of the package can not be installed under the vendor directory
GOFLAGS='' go install github.com/onsi/ginkgo/ginkgo@v1.16.5
fi

NO_COLOR=""
Expand Down
2 changes: 2 additions & 0 deletions manifests/45-webhook-configuration.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,6 +26,8 @@ apiVersion: admissionregistration.k8s.io/v1
kind: ValidatingWebhookConfiguration
metadata:
annotations:
include.release.openshift.io/self-managed-high-availability: "true"
include.release.openshift.io/single-node-developer: "true"
service.beta.openshift.io/inject-cabundle: "true"
name: performance-addon-operator
webhooks:
Expand Down