Skip to content

PerformanceProfileCreator build and functional test execution adaptation.#325

Merged
openshift-merge-robot merged 1 commit intoopenshift:masterfrom
jlojosnegros:ppc_functest_exec
Apr 8, 2022
Merged

PerformanceProfileCreator build and functional test execution adaptation.#325
openshift-merge-robot merged 1 commit intoopenshift:masterfrom
jlojosnegros:ppc_functest_exec

Conversation

@jlojosnegros
Copy link
Contributor

@jlojosnegros jlojosnegros commented Mar 25, 2022 •
edited
Loading

Align PPC with new folder structure in NTO

  • Create new targets in Makefile to build PPC and execute functional tests
  • Modify paths in functional tests to adapt them to the new folder
    structure.

This PR depends on #322 and its related with #324

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Mar 25, 2022

Hi @jlojosnegros. Thanks for your PR.

I'm waiting for a openshift member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Mar 25, 2022
@jlojosnegros jlojosnegros changed the title PerformanceProfileCreator build and functional test execution adatation. WIP PerformanceProfileCreator build and functional test execution adatation. Mar 25, 2022
@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Mar 25, 2022
yanirq
yanirq reviewed Mar 25, 2022
View reviewed changes
ffromani
ffromani reviewed Mar 25, 2022
View reviewed changes
@openshift-ci openshift-ci bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Mar 28, 2022
@openshift-ci openshift-ci bot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Mar 28, 2022
@ffromani
Copy link
Contributor

ffromani commented Mar 28, 2022

/ok-to-test

@openshift-ci openshift-ci bot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Mar 28, 2022
jlojosnegros
jlojosnegros commented Mar 28, 2022
View reviewed changes
ffromani
ffromani reviewed Mar 28, 2022
View reviewed changes
@jlojosnegros jlojosnegros force-pushed the ppc_functest_exec branch 2 times, most recently from 7971e40 to 0a09d4c Compare March 28, 2022 11:07
@jlojosnegros
Copy link
Contributor Author

jlojosnegros commented Mar 28, 2022 •
edited
Loading

Having problems while installing ginkgo in ci/prow/e2e-gcp-pao. ( this -> golang/go#45811 )
See #328 for a solution discussion.

@jlojosnegros jlojosnegros mentioned this pull request Mar 28, 2022
Merged
@jlojosnegros jlojosnegros changed the title WIP PerformanceProfileCreator build and functional test execution adatation. WIP PerformanceProfileCreator build and functional test execution adaptation. Mar 28, 2022
@openshift-ci openshift-ci bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Mar 31, 2022
@openshift-ci openshift-ci bot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Apr 5, 2022
@jlojosnegros
Copy link
Contributor Author

jlojosnegros commented Apr 5, 2022

rebased onto new master

@jlojosnegros jlojosnegros changed the title WIP PerformanceProfileCreator build and functional test execution adaptation. PerformanceProfileCreator build and functional test execution adaptation. Apr 5, 2022
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Apr 5, 2022
@jlojosnegros
Copy link
Contributor Author

jlojosnegros commented Apr 6, 2022

/test e2e-gcp-pao

yanirq
yanirq reviewed Apr 7, 2022
View reviewed changes
@jlojosnegros
Align PPC with new folder structure in NTO
eec7a41 
Create new targets in Makefile to build PPC and execute functional tests
Modify paths in functional tests to adapt them to the new folder
structure.

Signed-off-by: Jose Luis Ojosnegros Manchón <jojosneg@redhat.com>
@yanirq
Copy link
Contributor

yanirq commented Apr 7, 2022

The ci/prow/e2e-aws-operator failure looks real, although I'm not sure how it relates to this PR.
Maybe a flake or a new discovery of an error after nightly/CI were updated.

@jlojosnegros
Copy link
Contributor Author

jlojosnegros commented Apr 7, 2022

Let's retest the other lanes and unhold the PR and try to take a look at the e2e-aws-operator
/test e2e-aws
/test e2e-upgrade
/unhold

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 7, 2022
@jlojosnegros
Copy link
Contributor Author

jlojosnegros commented Apr 7, 2022

The ci/prow/e2e-aws-operator failure looks real, although I'm not sure how it relates to this PR. Maybe a flake or a new discovery of an error after nightly/CI were updated.

I have been looking for a while and It seems there have been a connection failure :

STEP: removing label tuned.openshift.io/hugepages from node ip-10-0-143-159.us-west-2.compute.internal
run command 'oc [label node --overwrite ip-10-0-143-159.us-west-2.compute.internal tuned.openshift.io/hugepages-]':
  out=
  err=The connection to the server api.ci-op-6cmbpgq0-0519c.origin-ci-int-aws.dev.rhcloud.com:6443 was refused - did you specify the right host or port?
  ret=exit status 1

So it does not seems to be related with our PR.
@yanirq , if I am not missing something important I will retest

@jlojosnegros
Copy link
Contributor Author

jlojosnegros commented Apr 7, 2022

/test e2e-aws-operator

@yanirq
Copy link
Contributor

yanirq commented Apr 8, 2022

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Apr 8, 2022
@yanirq
Copy link
Contributor

yanirq commented Apr 8, 2022

@jmencak we will need an approve tag there

@ffromani
Copy link
Contributor

ffromani commented Apr 8, 2022

/lgtm

@jmencak
Copy link
Contributor

jmencak commented Apr 8, 2022

Thank you for the PR, Jose.
/approve

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Apr 8, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jlojosnegros, jmencak

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 8, 2022
@openshift-bot
Copy link
Contributor

openshift-bot commented Apr 8, 2022

/retest-required

Please review the full test history for this PR and help us cut down flakes.

1 similar comment
@openshift-bot
Copy link
Contributor

openshift-bot commented Apr 8, 2022

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@yanirq
Copy link
Contributor

yanirq commented Apr 8, 2022

/retest

@openshift-bot
Copy link
Contributor

openshift-bot commented Apr 8, 2022

/retest-required

Please review the full test history for this PR and help us cut down flakes.

3 similar comments
@openshift-bot
Copy link
Contributor

openshift-bot commented Apr 8, 2022

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

openshift-bot commented Apr 8, 2022

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

openshift-bot commented Apr 8, 2022

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Apr 8, 2022

@jlojosnegros: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-merge-robot openshift-merge-robot merged commit 1316041 into openshift:master Apr 8, 2022
IlyaTyomkin pushed a commit to IlyaTyomkin/cluster-node-tuning-operator that referenced this pull request May 23, 2023
@jlojosnegros @IlyaTyomkin
Align PPC with new folder structure in NTO (openshift#325)
1d27530 
Create new targets in Makefile to build PPC and execute functional tests
Modify paths in functional tests to adapt them to the new folder
structure.

Signed-off-by: Jose Luis Ojosnegros Manchón <jojosneg@redhat.com>
IlyaTyomkin pushed a commit to IlyaTyomkin/cluster-node-tuning-operator that referenced this pull request Jun 13, 2023
@jlojosnegros @IlyaTyomkin
Align PPC with new folder structure in NTO (openshift#325)
ddb4d1a 
Create new targets in Makefile to build PPC and execute functional tests
Modify paths in functional tests to adapt them to the new folder
structure.

Signed-off-by: Jose Luis Ojosnegros Manchón <jojosneg@redhat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ArangoGutierrez ArangoGutierrez Awaiting requested review from ArangoGutierrez

@dagrayvid dagrayvid Awaiting requested review from dagrayvid

3 more reviewers

@yanirq yanirq yanirq left review comments

@jmencak jmencak jmencak left review comments

@ffromani ffromani ffromani left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@yanirq yanirq

@ffromani ffromani

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@jlojosnegros @ffromani @jmencak @yanirq @openshift-bot @openshift-merge-robot

Comments