feat: library-go bump

[eggfoobar]

Bumping the library-go dependency to latest, this should take advantage of leader election changes for SNO clusters proposed in this library-go PR.

Changes:

• updated library go to latest
• moved leader election config to util pkg
• updated to use leader election configs from library-go

Signed-off-by: ehila ehila@redhat.com

[jmencak]

/test e2e-upgrade

[jmencak]

/cc @yanirq something to be aware of that needs to be supported by the future NTO/PAO rewrite/merge.

[yanirq]

/cc @yanirq something to be aware of that needs to be supported by the future NTO/PAO rewrite/merge.

rewrite will need to be rebase. Movement of PAO will contain this update openshift-kni/performance-addon-operators#795
Once we switch to controller runtime libs we will need to update the newManager builder to have:

	LeaseDuration:      &le.LeaseDuration.Duration,
	RetryPeriod:        &le.RetryPeriod.Duration,
	RenewDeadline:      &le.RenewDeadline.Duration,

[jmencak]

/test e2e-upgrade

[jmencak]

Thank you for the PR, @eggfoobar , however this doesn't seem to be working as expected at the moment. Tested on a HA cluster and SNO cluster and seeing HA cluster leader election values in both cases.

W1214 12:41:11.705444       1 leaderelection.go:30] unable to get cluster infrastructure status, using HA cluster values for leader election: infrastructures.config.openshift.io "cluster" is forbidden: User "system:serviceaccount:openshift-cluster-node-tuning-operator:cluster-node-tuning-operator" cannot get resource "infrastructures" in API group "config.openshift.io" at the cluster scope

Sounds like some perms are missing.

[jmencak]

Thank you for the PR, this seems to work for me after the following change:

--- a/manifests/40-rbac.yaml
+++ b/manifests/40-rbac.yaml
@@ -48,9 +48,10 @@ rules:
 - apiGroups: [""]
   resources: ["nodes/metrics","nodes/specs"]
   verbs: ["get"]
-# Needed by every CVO-managed operator.
+# clusteroperators are needed by every CVO-managed operator,
+# infrastructures by the leader election code.
 - apiGroups: ["config.openshift.io"]
-  resources: ["clusteroperators"]
+  resources: ["clusteroperators", "infrastructures"]
   verbs: ["create","get","list","watch"]
 # Needed by every CVO-managed operator.
 - apiGroups: ["config.openshift.io"]

[eggfoobar]

Thanks so much @jmencak ! Removing the WIP

[jmencak]

Thanks so much @jmencak ! Removing the WIP

No worries, will you push the fix and squash so that I can approve this? Thank you!

[eggfoobar]

Absolutely, updated :)

[jmencak]

Retested.

/lgtm
/approve

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: eggfoobar, jmencak

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• OWNERS [jmencak]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[openshift-bot]

/retest-required

Please review the full test history for this PR and help us cut down flakes.

[openshift-bot]

/retest-required

Please review the full test history for this PR and help us cut down flakes.

[openshift-ci]

@eggfoobar: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.