Skip to content

Comments

WIP: Refactor controller runtime#289

Closed
cynepco3hahue wants to merge 6 commits intoopenshift:masterfrom
cynepco3hahue:refactor_controller_runtime
Closed

WIP: Refactor controller runtime#289
cynepco3hahue wants to merge 6 commits intoopenshift:masterfrom
cynepco3hahue:refactor_controller_runtime

Conversation

@cynepco3hahue
Copy link

@cynepco3hahue cynepco3hahue commented Nov 9, 2021

No description provided.

@cynepco3hahue cynepco3hahue changed the title Refactor controller runtime WIP: Refactor controller runtime Nov 9, 2021
@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Nov 9, 2021
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Nov 9, 2021

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: cynepco3hahue
To complete the pull request process, please assign kpouget after the PR has been reviewed.
You can assign the PR to them by writing /assign @kpouget in a comment when ready.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot requested review from jmencak and kpouget November 9, 2021 11:12
@openshift-ci openshift-ci bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Nov 14, 2021
@cynepco3hahue cynepco3hahue force-pushed the refactor_controller_runtime branch from da84407 to 1a7b5cd Compare November 15, 2021 09:14
@openshift-ci openshift-ci bot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Nov 15, 2021
yanirq
yanirq reviewed Nov 15, 2021
View reviewed changes
pkg/operator/reconciler.go

const ClusterOperatorName = "node-tuning"

// Reconciler reconciles a Tuned object and creates the tuned daemon set
Copy link
Contributor

@yanirq yanirq Nov 15, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is ment for the CO and not tuned object I assume

yanirq
yanirq reviewed Nov 15, 2021
View reviewed changes
pkg/operator/reconciler.go Outdated
return reconcile.Result{}, nil
}

func (r *Reconciler) syncDaemonSet() {
Copy link
Contributor

@yanirq yanirq Nov 15, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this should be removed from the current controller and handled in the CVO controller ?

@openshift-ci openshift-ci bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Dec 19, 2021
Artyom Lukianov added 2 commits December 22, 2021 15:49
vendor: get controller-runtime dependencies
15620d7 
Signed-off-by: Artyom Lukianov <alukiano@redhat.com>
controller: wait for pod and node cache sync
c20a399 
Signed-off-by: Artyom Lukianov <alukiano@redhat.com>
@cynepco3hahue cynepco3hahue force-pushed the refactor_controller_runtime branch from 1a7b5cd to e1116d5 Compare December 22, 2021 13:50
@openshift-ci openshift-ci bot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Dec 22, 2021
Artyom Lukianov added 2 commits December 23, 2021 17:06
metrics: update NTO metrics to work with the controller-runtime
b9dacf7 
Signed-off-by: Artyom Lukianov <alukiano@redhat.com>
main: update to work with the controller-runtime
54f4f07 
Signed-off-by: Artyom Lukianov <alukiano@redhat.com>
@cynepco3hahue cynepco3hahue force-pushed the refactor_controller_runtime branch 2 times, most recently from ded8226 to 1ca3514 Compare December 26, 2021 11:43
Artyom Lukianov added 2 commits December 27, 2021 11:18
operator: implement Reconciler interface
b95c781 
Signed-off-by: Artyom Lukianov <alukiano@redhat.com>
Update centos dockerfile
c2ade74 
- use golang 1.17
- fix the copy directive

Signed-off-by: Artyom Lukianov <alukiano@redhat.com>
@cynepco3hahue cynepco3hahue force-pushed the refactor_controller_runtime branch from 1ca3514 to c2ade74 Compare December 27, 2021 09:18
@cynepco3hahue
Copy link
Author

cynepco3hahue commented Dec 27, 2021

/retest

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Dec 27, 2021

@cynepco3hahue: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-aws-operator c2ade74 link true /test e2e-aws-operator
ci/prow/e2e-aws c2ade74 link true /test e2e-aws
ci/prow/e2e-upgrade c2ade74 link true /test e2e-upgrade

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@yanirq
Copy link
Contributor

yanirq commented Jan 10, 2022

@cynepco3hahue you can close this PR in favor of #302

@cynepco3hahue
Copy link
Author

cynepco3hahue commented Jan 11, 2022

Close in favor of #302

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jmencak jmencak Awaiting requested review from jmencak

@kpouget kpouget Awaiting requested review from kpouget

1 more reviewer

@yanirq yanirq yanirq left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@cynepco3hahue @yanirq