add current profile annotations to CVO manifests #167
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is matches openshift/enhancements#414 and doesn't change existing behavior
Contributor
|
/uncc @dagrayvid |
openshift-ci-robot
requested review from
jmencak
and removed request for
dagrayvid
Contributor
|
/assign @jmencak |
Contributor
|
This matches the name in https://github.com/openshift/enhancements/blob/master/enhancements/update/cluster-profiles.md#proposal . /lgtm |
jmencak
approved these changes
Oct 26, 2020
Contributor
jmencak
left a comment
jmencak
left a comment
There was a problem hiding this comment.
/lgtm
Thank you for the PR.
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: deads2k, guillaumerose, jmencak The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci-robot
added
the
approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is matches openshift/enhancements#414 and doesn't change existing behavior